Re: [PATCH] regulator: max77802: Add input supply properties to DT binding doc

[Javier Martinez Canillas <javier@osg.samsung.com>]

Hello Rob,

Thanks for your feedback.

On 10/05/2015 06:15 PM, Rob Herring wrote:
> On Mon, Oct 5, 2015 at 10:07 AM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
>> The max77802 regulator driver defines the supply name for each regulator
>> so these can be described in DT but is not mentioned in the binding doc.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>>  .../devicetree/bindings/regulator/max77802.txt     | 23 +++++++++++++++++++++-
>>  1 file changed, 22 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/max77802.txt b/Documentation/devicetree/bindings/regulator/max77802.txt
>> index 79e5476444f7..b466689c47ea 100644
>> --- a/Documentation/devicetree/bindings/regulator/max77802.txt
>> +++ b/Documentation/devicetree/bindings/regulator/max77802.txt
>> @@ -8,7 +8,26 @@ regulators that can be controlled over I2C.
>>
>>  Following properties should be present in main device node of the MFD chip.
>>
>> -Optional node:
> 
> regulators is still a node, so you should have 2 sections.
>

You are right, I included both because I saw other DT bindings doing
this but agree the correct approach is to have two separate sections.

Mark already applied this patch though so I can't send a v2 but I'll
post an incremental patch on top of his topic/max77802 branch:

https://git.kernel.org/cgit/linux/kernel/git/broonie/regulator.git/log/?h=topic/max77802

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America