From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbbJERdw (ORCPT ); Mon, 5 Oct 2015 13:33:52 -0400 Received: from lists.s-osg.org ([54.187.51.154]:47370 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbbJERdu (ORCPT ); Mon, 5 Oct 2015 13:33:50 -0400 Subject: Re: [PATCH] regulator: max77802: Add input supply properties to DT binding doc To: Rob Herring References: <1444057643-29672-1-git-send-email-javier@osg.samsung.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Liam Girdwood , Krzysztof Kozlowski , Mark Brown Message-ID: <5612B478.7030802@osg.samsung.com> Date: Mon, 5 Oct 2015 19:33:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, Thanks for your feedback. On 10/05/2015 06:15 PM, Rob Herring wrote: > On Mon, Oct 5, 2015 at 10:07 AM, Javier Martinez Canillas > wrote: >> The max77802 regulator driver defines the supply name for each regulator >> so these can be described in DT but is not mentioned in the binding doc. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> .../devicetree/bindings/regulator/max77802.txt | 23 +++++++++++++++++++++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/max77802.txt b/Documentation/devicetree/bindings/regulator/max77802.txt >> index 79e5476444f7..b466689c47ea 100644 >> --- a/Documentation/devicetree/bindings/regulator/max77802.txt >> +++ b/Documentation/devicetree/bindings/regulator/max77802.txt >> @@ -8,7 +8,26 @@ regulators that can be controlled over I2C. >> >> Following properties should be present in main device node of the MFD chip. >> >> -Optional node: > > regulators is still a node, so you should have 2 sections. > You are right, I included both because I saw other DT bindings doing this but agree the correct approach is to have two separate sections. Mark already applied this patch though so I can't send a v2 but I'll post an incremental patch on top of his topic/max77802 branch: https://git.kernel.org/cgit/linux/kernel/git/broonie/regulator.git/log/?h=topic/max77802 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America