From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752079AbbJFHFa (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Oct 2015 03:05:30 -0400
Received: from mx2.suse.de ([195.135.220.15]:49974 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751700AbbJFHF1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Oct 2015 03:05:27 -0400
Subject: Re: [PATCH v4 1/4] mm, documentation: clarify /proc/pid/status VmSwap
 limitations
To: Hugh Dickins <hughd@google.com>
References: <1443792951-13944-1-git-send-email-vbabka@suse.cz>
 <1443792951-13944-2-git-send-email-vbabka@suse.cz>
 <alpine.LSU.2.11.1510041756330.15067@eggly.anvils>
Cc: linux-mm@kvack.org, Jerome Marchand <jmarchan@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        Michal Hocko <mhocko@suse.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Cyrill Gorcunov <gorcunov@openvz.org>,
        Randy Dunlap <rdunlap@infradead.org>, linux-s390@vger.kernel.org,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Paul Mackerras <paulus@samba.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Oleg Nesterov <oleg@redhat.com>, Linux API <linux-api@vger.kernel.org>,
        Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
From: Vlastimil Babka <vbabka@suse.cz>
Message-ID: <561372B3.60504@suse.cz>
Date: Tue, 6 Oct 2015 09:05:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.LSU.2.11.1510041756330.15067@eggly.anvils>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05/2015 03:05 AM, Hugh Dickins wrote:
> On Fri, 2 Oct 2015, Vlastimil Babka wrote:
>> --- a/Documentation/filesystems/proc.txt
>> +++ b/Documentation/filesystems/proc.txt
>> @@ -239,6 +239,8 @@ Table 1-2: Contents of the status files (as of 4.1)
>>    VmPTE                       size of page table entries
>>    VmPMD                       size of second level page tables
>>    VmSwap                      size of swap usage (the number of referred swapents)
>> +                             by anonymous private data (shmem swap usage is not
>> +                             included)
>
> I have difficulty in reading "size of swap usage (the number of referred
> swapents) by anonymous private data (shmem swap usage is not included)".
>
> Luckily, VmSwap never was "the number of referred swapents", it's in kB.
> So I suggest                    amount of swap used by anonymous private data
>                                  (shmem swap usage is not included)

Good point, thanks!

> for which you can assume Acked-by: Hugh Dickins <hughd@google.com>
>
> Hugh
>