From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752726AbbJFLP5 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Oct 2015 07:15:57 -0400
Received: from mail-la0-f47.google.com ([209.85.215.47]:34734 "EHLO
	mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752112AbbJFLPz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Oct 2015 07:15:55 -0400
Subject: Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove
To: Neil Armstrong <narmstrong@baylibre.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Guenter Roeck <linux@roeck-us.net>,
        vivien.didelot@savoirfairelinux.com, Andrew Lunn <andrew@lunn.ch>,
        Fabian Frederick <fabf@skynet.be>,
        Pavel Nakonechny <pavel.nakonechny@skitlab.ru>,
        Joe Perches <joe@perches.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, nbd@openwrt.org
References: <560FE575.7000003@baylibre.com>
 <560FE731.6050600@cogentembedded.com> <560FF239.2060903@baylibre.com>
 <56104E99.5020105@cogentembedded.com> <5613776D.8060103@baylibre.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <5613AD68.1020600@cogentembedded.com>
Date: Tue, 6 Oct 2015 14:15:52 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <5613776D.8060103@baylibre.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 10/6/2015 10:25 AM, Neil Armstrong wrote:

>>>>> To prevent memory leakage on unbinding, add missing kfree calls.
>>>>>
>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>> ---
>>>>>     net/dsa/dsa.c | 5 ++++-
>>>>>     1 file changed, 4 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
>>>>> index c59fa5d..12cec40 100644
>>>>> --- a/net/dsa/dsa.c
>>>>> +++ b/net/dsa/dsa.c
>>>>> @@ -914,8 +914,10 @@ static void dsa_remove_dst(struct dsa_switch_tree *dst)
>>>>>         for (i = 0; i < dst->pd->nr_chips; i++) {
>>>>>             struct dsa_switch *ds = dst->ds[i];
>>>>>
>>>>> -        if (ds != NULL)
>>>>> +        if (ds != NULL) {
>>>>
>>>>      Didn;t scripts/checkpatch.pl complain here? just if (ds) is preferred in the networking code.
>>>>
>>>> MBR, Sergei
>>>>
>>> Yes,
>>>
>>> But I considered the cosmetic changes are not the subject of this serie.
>>
>>     Formally, all the patches should be checkpatch-clean...
>>
>>> Neil
>>
>> MBR, Sergei
>>
> Sure,

> How should I handle this case ?
> A separate patch with the cosmetic change before the kfree addition ?

    No, that would classify as a cleanup, and cleanups shouldn't be queued 
before fixes (should be the other way around). Just do this in this same 
patch, possibly mentioning in the change log.

> Neil

MBR, Sergei