From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbbJFMSL (ORCPT ); Tue, 6 Oct 2015 08:18:11 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:51126 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbbJFMSJ (ORCPT ); Tue, 6 Oct 2015 08:18:09 -0400 Subject: Re: [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC To: Tony Lindgren , References: <1444133636-31430-1-git-send-email-tony@atomide.com> CC: From: Roger Quadros Message-ID: <5613BBFD.60401@ti.com> Date: Tue, 6 Oct 2015 15:18:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444133636-31430-1-git-send-email-tony@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/15 15:13, Tony Lindgren wrote: > Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") > added a debug option for GPMC, but somehow managed to keep it unselectable. > > This probably happened because I had some uncommitted changes and the > GPMC option is selected in the platform specific Kconfig. > > Let's also update the description a bit, it does not mention that > enabling the debug option also disables the reset of GPMC controller > during the init as pointed out by Uwe Kleine-König > . > > Fixes: 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") > Reported-by: Uwe Kleine-König > Signed-off-by: Tony Lindgren Acked-by: Roger Quadros > --- > drivers/memory/Kconfig | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -58,12 +58,13 @@ config OMAP_GPMC > memory drives like NOR, NAND, OneNAND, SRAM. > > config OMAP_GPMC_DEBUG > - bool > + bool "Enable GPMC debug output and skip reset of GPMC during init" > depends on OMAP_GPMC > help > Enables verbose debugging mostly to decode the bootloader provided > - timings. Enable this during development to configure devices > - connected to the GPMC bus. > + timings. To preserve the bootloader provided timings, the reset > + of GPMC is skipped during init. Enable this during development to > + configure devices connected to the GPMC bus. > > config MVEBU_DEVBUS > bool "Marvell EBU Device Bus Controller" > -- cheers, -roger