From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbbJFM3E (ORCPT ); Tue, 6 Oct 2015 08:29:04 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:40396 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbbJFM3B (ORCPT ); Tue, 6 Oct 2015 08:29:01 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f791c6d000001498-d3-5613be8bc0ce Content-transfer-encoding: 8BIT Message-id: <5613BE8B.3030403@samsung.com> Date: Tue, 06 Oct 2015 21:28:59 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Roger Quadros , linux-kernel@vger.kernel.org Cc: k.kozlowski@samsung.com, ckeepax@opensource.wolfsonmicro.com, gregkh@linuxfoundation.org, ramakrishna.pallala@intel.com, patches@opensource.wolfsonmicro.com, myungjoo.ham@samsung.com Subject: Re: [PATCH 2/2] extcon: Add the support of EXTCON_CHG_USB when SDP port is attached or detached References: <1444130485-23325-1-git-send-email-cw00.choi@samsung.com> <1444130485-23325-3-git-send-email-cw00.choi@samsung.com> <5613B553.9080005@ti.com> <5613BAB9.7070105@samsung.com> <5613BD10.3070300@ti.com> In-reply-to: <5613BD10.3070300@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkSLd7n3CYQetrOYt/U26wWzQvXs9m 8fqFocXlXXPYLG43rmCzWP72P5vFwjc3mSx6Hmk5cHgs3vOSyWP/3DXsHi8n/mbz6NuyitHj +I3tTB6fN8kFsEVx2aSk5mSWpRbp2yVwZZx81sVSsI6/4tXVS2wNjBN5uhg5OCQETCR2Ncd3 MXICmWISF+6tZ+ti5OIQEljBKLHt9Ds2mJrtv8wh4rMYJRrXPWYBaeAVEJT4MfkeC0gNs4C8 xJFL2RCmusSUKbkQ5Q8YJd5fWssEUa4lcexHOyuIzSKgKrF90y8wmw0ovv/FDbBVogIREt0n KkHCIgL2Er2zZ4GVMAvsY5RYP6McxBYWyJLo/zGbBWL+DUaJ34+7wYo4BdQkls95CHa/hMA9 domWVbuZIJYJSHybfIgF4hdZiU0HmCH+lZQ4uOIGywRGsVlIvpmF8M0shG8WMDKvYhRNLUgu KE5KLzLSK07MLS7NS9dLzs/dxAiMvtP/nvXtYLx5wPoQowAHoxIPr8RNoTAh1sSy4srcQ4ym QDdMZJYSTc4HxnheSbyhsZmRhamJqbGRuaWZkjhvgtTPYCGB9MSS1OzU1ILUovii0pzU4kOM TBycUg2Miv4sJzSuzVjStn9T5ueVfkWRHHv+pkxPMNJaVX7xhPHSN0fsjotnSs25/17dc/vN U9JrRKN+lTnyGMwWKF5g3GlZsvvN81v3jARj5GYu6QnrfxC4Z+Xxmy4rHZOYr25vODBDYnWS Qu+B/sftnSEfKovvTFy5Qjtkce7ZuOeH95XWyHGJzw0LV2Ipzkg01GIuKk4EAAn75KK5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t9jQd3ufcJhBgcPSFr8m3KD3aJ58Xo2 i9cvDC0u75rDZnG7cQWbxfK3/9ksFr65yWTR80jLgcNj8Z6XTB77565h93g58TebR9+WVYwe x29sZ/L4vEkugC2qgdEmIzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJ xSdA1y0zB+geJYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWPGyWddLAXr +CteXb3E1sA4kaeLkYNDQsBEYvsv8y5GTiBTTOLCvfVsXYxcHEICsxglGtc9ZgFJ8AoISvyY fI8FpJ5ZQF7iyKVsCFNdYsqUXIjyB4wS7y+tZYIo15I49qOdFcRmEVCV2L7pF5jNBhTf/+IG G0ivqECERPeJSpCwiIC9RO/sWWAlzAL7GCXWzygHsYUFsiT6f8xmgZh/g1Hi9+NusCJOATWJ 5XMesk1gBDoS4bpZCNfNQrhuASPzKkaJ1ILkguKk9FyjvNRyveLE3OLSvHS95PzcTYzgGH8m vYPx8C73Q4wCHIxKPLwSN4XChFgTy4orcw8xSnAwK4nw3p0iHCbEm5JYWZValB9fVJqTWnyI 0RTovYnMUqLJ+cD0k1cSb2hsYmZkaWRuaGFkbK4kznvjEEOYkEB6YklqdmpqQWoRTB8TB6dU A6Mb/0HXjMNSbVcas250nrNL5XXd9Pvv8Q/LX2qKqxyu3JTSyfVxXs45q6zCI4wKLUvfPDF1 fibHZtyoeuDB9ztZQccu7jXIyN5g+tTqydXVVg6xymvYmUqmmZ0uZs575/DV/undglTOZxOi Zd97bMi88y77sK3LbjHlNTI7EmU+l6mIPq3dOFeJpTgj0VCLuag4EQB7q2R9BwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Roger, On 2015년 10월 06일 21:22, Roger Quadros wrote: > Chanwoo, > > On 06/10/15 15:12, Chanwoo Choi wrote: >> Roger, >> >> On 2015년 10월 06일 20:49, Roger Quadros wrote: >>> Hi, >>> >>> On 06/10/15 14:21, Chanwoo Choi wrote: >>>> The SDP (Standard Downstream Port) is one of various USB Charging ports. The SDP >>>> supports both the data transmission and the charging through USB connector at >>>> the same time. So, the EXTCON framework defines two connector type for USB SDP >>>> connector as following: >>>> - EXTCON_USB means the USB cable for data transmission. >>>> - EXTCON_CHG_USB means the USB charger cable for battery charging. >>>> >>>> This patch add the support of EXTCON_CHG_USB when USB SDP is attached or >>>> detached. >>> >>> I didn't understand why this change is needed. SDP, EXTCON_USB and EXTCON_CHG_USB >>> are the same thing. no? >> >> As you knew, SDP support both data transmission and charging >> through one port at the same time. Also, On patch1 of this patch-set, >> I add the prefix to clarify both attribute and meaning of external connector as following: >> - EXTCON_CHG_* mean the charger connector. >> >> So, there are three possible naming approach for USB SDP. >> >> Approach 1. >> - EXTCON_USB /* SDP for both data transmission and charging */ >> >> Approach 2. >> - EXTCON_USB /* SDP for data transmission */ >> - EXTCON_CHG_USB /* SDP for charging */ > > This only adds confusion. There is only one cable that will always do both jobs > so no point in using 2 names for it. OK. I'll drop it. > >> >> Approach 3. >> - EXTCON_CHG_USB /* SDP for both data transmission and charging */ >> >> It is not fixed about name. I want to discuss what is proper name for USB SDP. > > I do not have any preference over 1 or 3. I'll drop this patch. Also, I'll use only EXTCON_USB and delete the EXTCON_CHG_USB from patch1 on next version. Thanks, Chanwoo Choi