From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752719AbbJFR7O (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Oct 2015 13:59:14 -0400
Received: from lists.s-osg.org ([54.187.51.154]:47512 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751531AbbJFR7M (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Oct 2015 13:59:12 -0400
Subject: Re: [PATCH v2 0/2] selftests/pstore: add pstore test script
To: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>,
        linux-kernel@vger.kernel.org
References: <20151002114637.20957.61769.stgit@arietta>
Cc: Tony Luck <tony.luck@intel.com>, Kees Cook <keescook@chromium.org>,
        linux-api@vger.kernel.org, Anton Vorontsov <anton@enomsg.org>,
        Mark Salyzyn <salyzyn@android.com>, Colin Cross <ccross@android.com>,
        Seiji Aguchi <seiji.aguchi.tr@hitachi.com>,
        Shuah Khan <shuahkh@osg.samsung.com>
From: Shuah Khan <shuahkh@osg.samsung.com>
Organization: Samsung Open Source Group
Message-ID: <56140BED.7040507@osg.samsung.com>
Date: Tue, 6 Oct 2015 11:59:09 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20151002114637.20957.61769.stgit@arietta>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/02/2015 05:46 AM, Hiraku Toyooka wrote:
> These scripts include test cases which check pstore behavior. This
> is useful to avoid regressions of pstore.
> 
> Changes since v1:
>  * Exit with 1 in pstore/Makefile when pstore_crash_test failed.
>  * Create helper functions to make the tests much more readable.
>  * Use /sys/module/pstore/parameters/backend to check pstore backend is
>    registered.
>  * Show content of /sys/module/.../backend and /proc/cmdline for debug
>  * Give UUID to each execution of test script.
>  * Write unique test string with UUID into pmsg.
>  * Check only one test string pattern appears in pmsg after crash.
>  * Check UUID written to pmsg matches across crash.
>  * Don't touch panic_on_oops because it is not necessary for reboot on crash
> 
> (v1: http://www.kernelhub.org/?msg=831044&p=2)
> 
> I also confirmed that these scripts work fine with kdump reboot with
> kernel boot parameter 'crash_kexec_post_notifiers'.

Thanks. Applied to linux-kselftest next for 4.4

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978