From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbbJFVCt (ORCPT ); Tue, 6 Oct 2015 17:02:49 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:34382 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbbJFVCr (ORCPT ); Tue, 6 Oct 2015 17:02:47 -0400 Subject: Re: [PATCH] bridge/netfilter: avoid unused label warning To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <7985748.1v9Gzszd4T@wuerfel> <561420DD.70009@cumulusnetworks.com> <5966552.c0Emgm27oa@wuerfel> Cc: netdev@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, Pablo Neira Ayuso , David Miller , "Eric W. Biederman" From: Nikolay Aleksandrov Message-ID: <561436F5.70409@cumulusnetworks.com> Date: Tue, 6 Oct 2015 23:02:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5966552.c0Emgm27oa@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2015 09:39 PM, Arnd Bergmann wrote: > On Tuesday 06 October 2015 21:28:29 Nikolay Aleksandrov wrote: >> I posted a fix for this a couple of days ago, but I like your approach better. >> Since mine is not yet applied (I sent it to netfilter-devel only, wasn't sure which >> jurisdiction this falls into exactly) we can drop it. >> Just for reference my patch is here: >> http://patchwork.ozlabs.org/patch/526417/ >> Pablo, could you please drop it ? >> >> By the way this takes care of another warning about unused variable (nf_bridge), too. > > Hmm I did not get that one, at least not in 4.3-rc4. > You need to set W=1 $ git describe --abbrev=0 v4.3-rc4 net/bridge//br_netfilter_hooks.c: In function ‘br_nf_dev_queue_xmit’: net/bridge//br_netfilter_hooks.c:794:2: warning: label ‘drop’ defined but not used [-Wunused-label] drop: ^ net/bridge//br_netfilter_hooks.c:727:25: warning: variable ‘nf_bridge’ set but not used [-Wunused-but-set-variable] struct nf_bridge_info *nf_bridge; Cheers, Nik >> Reviewed-by: Nikolay Aleksandrov > > Thanks and sorry for missing the Cc to the netfilter list on my patch. > > Arnd