From: Vlad Zolotarov <vladz@cloudius-systems.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: linux-kernel@vger.kernel.org, mst@redhat.com, hjk@hansjkoch.de,
corbet@lwn.net, gregkh@linuxfoundation.org,
bruce.richardson@intel.com, avi@cloudius-systems.com,
gleb@cloudius-systems.com, alexander.duyck@gmail.com
Subject: Re: [PATCH v5 1/4] uio: add ioctl support
Date: Wed, 7 Oct 2015 11:17:06 +0300 [thread overview]
Message-ID: <5614D502.3030601@cloudius-systems.com> (raw)
In-Reply-To: <20151006223349.4befe0a0@samsung9>
On 10/07/15 00:33, Stephen Hemminger wrote:
> On Tue, 6 Oct 2015 20:17:36 +0300
> Vlad Zolotarov <vladz@cloudius-systems.com> wrote:
>
>> Add the ability for underlying device drivers to register the ioctl
>> commands. This is useful when some interaction with the user space
>> beyond sysfs capabilities is required, e.g. query the interrupt mode
>> or bind eventfd to interrupt notifications (similarly to vfio ioctl
>> VFIO_DEVICE_SET_IRQS).
>>
>> Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>
> After discussions on and off list, the idea of an ioctl interface
> is just not going to be accepted upstream because it can be abused.
> Therefore another API will be necessary.
I'm open for ideas. So far ioctl seems like the most appropriate
candidate for the job... ;)
>
> Ps: since I did most of this first,
this particular patch and parts of SET_IRQ code - yes. But that would be
all. Let's just be specific... ;)
This still doesn't mean that u don't deserve a proper credit for that.
;) But there was a reason why I didn't do that. See below.
> I am surprised you never gave
> any attribution for the earlier work.
If memory serves me well I asked u about the "attribution" a few days
ago of the dpdk-dev list but got no answer.
Therefore I took no steps in this regard since it left me under the
impression that u just didn't want it. However it seems now
that that's not the case... ;)
Pls., let me know if u want me to mention that this patch and SET_IRQ
ioctl code is based on your patches on dpdk-dev list and if yes, in which
form: just mentioning it in the patch description or putting your
signed-off to the patch(es).
thanks,
vlad
next prev parent reply other threads:[~2015-10-07 8:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 17:17 [PATCH v5 0/4] uio: add MSI/MSI-X support to uio_pci_generic driver Vlad Zolotarov
2015-10-06 17:17 ` [PATCH v5 1/4] uio: add ioctl support Vlad Zolotarov
2015-10-06 21:33 ` Stephen Hemminger
2015-10-07 8:17 ` Vlad Zolotarov [this message]
2015-10-07 8:18 ` Vlad Zolotarov
2015-10-07 8:46 ` Greg KH
2015-10-07 8:55 ` Vlad Zolotarov
2015-10-07 17:21 ` Greg KH
2015-10-07 17:28 ` Vlad Zolotarov
[not found] ` <CAOaVG17hMG7cAnD_DZ9J3pRMpXctx3o_EF8A62vtZx6Mv9c-2g@mail.gmail.com>
2015-10-07 19:00 ` Vlad Zolotarov
[not found] ` <CAOaVG147Fxq0VyohAFBvw4cxtLRw3qd2aNt-e2Vr4_R5EYs7zQ@mail.gmail.com>
2015-10-08 12:41 ` Vlad Zolotarov
2015-10-08 13:03 ` Greg Kroah-Hartman
2015-10-06 17:17 ` [PATCH v5 2/4] uio_pci_generic: properly initialize PCI bars mappings towards UIO Vlad Zolotarov
2015-10-06 17:17 ` [PATCH v5 3/4] uio_pci_generic: add MSI/MSI-X support Vlad Zolotarov
2015-10-06 21:36 ` Stephen Hemminger
2015-10-06 17:17 ` [PATCH v5 4/4] Documentation: update uio-howto Vlad Zolotarov
2015-10-06 18:27 ` [PATCH v5 0/4] uio: add MSI/MSI-X support to uio_pci_generic driver Michael S. Tsirkin
2015-10-06 20:35 ` Vlad Zolotarov
2015-10-06 20:48 ` Vlad Zolotarov
2015-10-06 22:51 ` Michael S. Tsirkin
2015-10-07 8:38 ` Vlad Zolotarov
2015-10-07 10:42 ` Michael S. Tsirkin
2015-10-07 13:44 ` Vlad Zolotarov
2015-10-07 13:55 ` Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614D502.3030601@cloudius-systems.com \
--to=vladz@cloudius-systems.com \
--cc=alexander.duyck@gmail.com \
--cc=avi@cloudius-systems.com \
--cc=bruce.richardson@intel.com \
--cc=corbet@lwn.net \
--cc=gleb@cloudius-systems.com \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).