From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbbJGISh (ORCPT ); Wed, 7 Oct 2015 04:18:37 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:34006 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbbJGISf (ORCPT ); Wed, 7 Oct 2015 04:18:35 -0400 Subject: Re: [PATCH v5 1/4] uio: add ioctl support To: Stephen Hemminger References: <1444151859-10217-1-git-send-email-vladz@cloudius-systems.com> <1444151859-10217-2-git-send-email-vladz@cloudius-systems.com> <20151006223349.4befe0a0@samsung9> <5614D502.3030601@cloudius-systems.com> Cc: linux-kernel@vger.kernel.org, mst@redhat.com, hjk@hansjkoch.de, corbet@lwn.net, gregkh@linuxfoundation.org, bruce.richardson@intel.com, avi@cloudius-systems.com, gleb@cloudius-systems.com, alexander.duyck@gmail.com From: Vlad Zolotarov Message-ID: <5614D556.6080805@cloudius-systems.com> Date: Wed, 7 Oct 2015 11:18:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <5614D502.3030601@cloudius-systems.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/15 11:17, Vlad Zolotarov wrote: > > > On 10/07/15 00:33, Stephen Hemminger wrote: >> On Tue, 6 Oct 2015 20:17:36 +0300 >> Vlad Zolotarov wrote: >> >>> Add the ability for underlying device drivers to register the ioctl >>> commands. This is useful when some interaction with the user space >>> beyond sysfs capabilities is required, e.g. query the interrupt mode >>> or bind eventfd to interrupt notifications (similarly to vfio ioctl >>> VFIO_DEVICE_SET_IRQS). >>> >>> Signed-off-by: Vlad Zolotarov >> After discussions on and off list, the idea of an ioctl interface >> is just not going to be accepted upstream because it can be abused. >> Therefore another API will be necessary. > > I'm open for ideas. So far ioctl seems like the most appropriate > candidate for the job... ;) > >> >> Ps: since I did most of this first, > > this particular patch and parts of SET_IRQ code - yes. But that would > be all. Let's just be specific... ;) Pardon - mapping bars was also snitched from your patches... ;) > This still doesn't mean that u don't deserve a proper credit for that. > ;) But there was a reason why I didn't do that. See below. >> I am surprised you never gave >> any attribution for the earlier work. > > If memory serves me well I asked u about the "attribution" a few days > ago of the dpdk-dev list but got no answer. > Therefore I took no steps in this regard since it left me under the > impression that u just didn't want it. However it seems now > that that's not the case... ;) > > Pls., let me know if u want me to mention that this patch and SET_IRQ > ioctl code is based on your patches on dpdk-dev list and if yes, in which > form: just mentioning it in the patch description or putting your > signed-off to the patch(es). > > thanks, > vlad >