From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752097AbbJGIWU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 7 Oct 2015 04:22:20 -0400
Received: from mga14.intel.com ([192.55.52.115]:3289 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751441AbbJGIWQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 7 Oct 2015 04:22:16 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,648,1437462000"; 
   d="scan'208";a="821133294"
Subject: Re: [PATCH] perf tools: get version from uname(2), not /proc
To: Jiri Olsa <jolsa@redhat.com>, Matt Mullins <mmullins@twopensource.com>
References: <1444171996-24030-1-git-send-email-mmullins@twopensource.com>
 <20151007081854.GA20302@krava.landal.opennet>
Cc: acme@kernel.org, Vinson Lee <vlee@twopensource.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        Kan Liang <kan.liang@intel.com>, Andi Kleen <ak@linux.intel.com>,
        linux-kernel@vger.kernel.org
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <5614D585.4010707@intel.com>
Date: Wed, 7 Oct 2015 11:19:17 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20151007081854.GA20302@krava.landal.opennet>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/10/15 11:18, Jiri Olsa wrote:
> On Tue, Oct 06, 2015 at 03:53:14PM -0700, Matt Mullins wrote:
>> Tools in kmod (e.g. modprobe) compose the module path from the release
>> from uname(2).  Because we use the UNAME26 personality, we need perf to
>> find modules located at the same path as the system tools.
> 
> I guess it's easy to google this up, but could you
> please state in the changelog what's the difference
> between the current version and the UNAME26 one?
> 
> Also state (and check) this change wouldn't affect other
> parts of the code that use this version (if there's any).

Isn't the machine root dir for guests? uname() won't work for them.