From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbbJGLO1 (ORCPT ); Wed, 7 Oct 2015 07:14:27 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:44467 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbbJGLOW (ORCPT ); Wed, 7 Oct 2015 07:14:22 -0400 Subject: Re: [PATCH] video: of: fix memory leak To: Sudip Mukherjee , Jean-Christophe Plagniol-Villard References: <1443606848-31510-1-git-send-email-sudipm.mukherjee@gmail.com> CC: , From: Tomi Valkeinen Message-ID: <5614FE88.4030909@ti.com> Date: Wed, 7 Oct 2015 14:14:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1443606848-31510-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pPrF4ATq2VJiTSPDn8HlkhTMT78gLf9cC" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pPrF4ATq2VJiTSPDn8HlkhTMT78gLf9cC Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 30/09/15 12:54, Sudip Mukherjee wrote: > If of_parse_display_timing() fails we are printing an error message and= > jumping to the error path but we missed freeing "dt". >=20 > Signed-off-by: Sudip Mukherjee > --- > drivers/video/of_display_timing.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_displ= ay_timing.c > index 32d8275..8a1076b 100644 > --- a/drivers/video/of_display_timing.c > +++ b/drivers/video/of_display_timing.c > @@ -210,6 +210,7 @@ struct display_timings *of_get_display_timings(stru= ct device_node *np) > */ > pr_err("%s: error in timing %d\n", > of_node_full_name(np), disp->num_timings + 1); > + kfree(dt); > goto timingfail; > } Thanks, queued for 4.3 fixes. Tomi --pPrF4ATq2VJiTSPDn8HlkhTMT78gLf9cC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWFP6IAAoJEPo9qoy8lh71TC8QAKU+wUc2zkuY6JrXenLKCpPD 2kjCjF0BSYiBUVuWRVi10CT4oGSttxulRTvxYcvr4zN8ho37Pj4L+SCtv9aCQ1Wo xC6lqPgszLc6PuVZeTXP8dcSvDc+v32uvOiQdiEFT8kKTOXPgpmDn26WL/DmbxmG JMI5fjjZFd9D5n6ad87LdxM9mlkXrEkECOiuMIrUEaUBTZHFCddP0P+HT/ZS2nza W39qh/AcC7CUK35ks+AUzll1ZdvrJfHwQyTUlx+TYwTxpXxs443plMP85J5BZKhp Y/nWrEjWFYWpzmHH7LOL78vQoJpnrFAvGTzBIbPoXB/g3yoym+XIitxMKFQLjyfF 97zYtSmFxwrJfA8WR6e1P26nJgj7C8EZE8kDwM9bQEcliID9leX8Uk5gsuFrdCAU US4WfVhuYsjUCLr+5D9hRh51pDwM04kpKIzzpe7JD8d3Vx8Tn0RXiTv/I5idjF5e Jqv7NGHJCGNYQj4+y3VINXYX2bWyHXxtiNFdKeFQD7+K+97lTC/HEYfkWIy70Rqn pzN/X6EUsVf8Gu8h2ZwwSIqU/Ciyrzhs9A36ZHwJWYGr4Zw2AlbxKP1nxwAJh4Nh dzIflJOSKejOBlnaga1fD7MUAxRaQ6bHUn8tk5JYNtg3gEitZIWTFegHhbwheexn nITKGIvBmHO2p5ULrIAL =8kqn -----END PGP SIGNATURE----- --pPrF4ATq2VJiTSPDn8HlkhTMT78gLf9cC--