From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbbJGNDp (ORCPT ); Wed, 7 Oct 2015 09:03:45 -0400 Received: from lists.s-osg.org ([54.187.51.154]:47645 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbbJGNDo (ORCPT ); Wed, 7 Oct 2015 09:03:44 -0400 Subject: Re: [PATCH] mfd: remove unused variables To: Arnd Bergmann , Lee Jones References: <7700818.mjdn6x2kkK@wuerfel> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <5615182B.5060902@osg.samsung.com> Date: Wed, 7 Oct 2015 15:03:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <7700818.mjdn6x2kkK@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Arnd, On 10/07/2015 02:49 PM, Arnd Bergmann wrote: > A mass-cleanup by Javier Martinez Canillas removed a lot of > unused code, but left at least two variables in mfd drivers > in place that are now causing warnings: > > drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl': > drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable] > drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe': > drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable] > > This removes them as well. > > Signed-off-by: Arnd Bergmann > Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic") > Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic") > --- I thought that I got rid of all the unused variables but somehow I missed these. Sorry and thanks a lot for taking care of this. > > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > index 193ecee1fa7e..5abcbb2e8849 100644 > --- a/drivers/mfd/lm3533-core.c > +++ b/drivers/mfd/lm3533-core.c > @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c, > const struct i2c_device_id *id) > { > struct lm3533 *lm3533; > - int ret; > > dev_dbg(&i2c->dev, "%s\n", __func__); > > diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c > index b98cf1de0a55..d63f3a896adb 100644 > --- a/drivers/mfd/rtsx_pcr.c > +++ b/drivers/mfd/rtsx_pcr.c > @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf); > > static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl) > { > - int err; > - > rtsx_pci_init_cmd(pcr); > > while (*tbl & 0xFFFF0000) { > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America