From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155AbbJGN6q (ORCPT ); Wed, 7 Oct 2015 09:58:46 -0400 Received: from mail-db3on0074.outbound.protection.outlook.com ([157.55.234.74]:3724 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752791AbbJGN6m (ORCPT ); Wed, 7 Oct 2015 09:58:42 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@ezchip.com; Subject: Re: [PATCH v2 2/3] word-at-a-time.h: support zero_bytemask() on alpha and tile To: Ingo Molnar References: <1444159429-4788-1-git-send-email-cmetcalf@ezchip.com> <1444159429-4788-3-git-send-email-cmetcalf@ezchip.com> <20151007055320.GA27737@gmail.com> CC: Michael Cree , Matt Turner , Michael Ellerman , Yoshinori Sato , Alexey Dobriyan , Rasmus Villemoes , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov , , Linux Kernel Mailing List From: Chris Metcalf Message-ID: <561524FF.20807@ezchip.com> Date: Wed, 7 Oct 2015 09:58:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151007055320.GA27737@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: CY1PR0801CA0005.namprd08.prod.outlook.com (25.163.136.143) To AM2PR02MB0771.eurprd02.prod.outlook.com (25.163.146.156) X-Microsoft-Exchange-Diagnostics: 1;AM2PR02MB0771;2:twsfQ0NNiY28Y1Oeq89RTw+KOsGeXMujTc/c3f+N3bNJbFDKjFoTuVIwCf/EFIZt419QQKJv+jVVHCTYdjpypbuqYilCVoYuaG5rTMjeP9sgJ7BzacPTC0MWoOXSOySNu83ttQfamxps41mWqvXIzv1L6r3w+TIiF86WyePn4Do=;3:D85molzkHyjRW5c7O9agO11AINPzxhws4zSuOy24w5kMaUlD7ye2VuLa7WwVbFUvlDTjDe4YNNK5qjNKLYAuju9CBZ2jih7BfiHzhUdNFOvFK8QH9G81Z8hEev7Lp5u9unbmYTPY0j2TvlQYnqvNqw==;25:Lo2kHAG7yqkRxngtKUur5LJGma++JE9uoV7044tooQjw0KzuIxXAJWtzT/6YonfYnxww5UyzkRVHV07W3MfK5BbDRBlzTPvLjdEygP4i8q8lCSf+TTyrTgSx/AgP7uE6+CRhwv6KipPSqlEBlNSK7sK2KbMQjQI0hgpByPzVSqaHRAg5fgKwBuRAaJP8IbJ0ABWfAGkf0Omqhz7mencD8U62TG+djUSZY6Q/7t0MnaVTx4bGESAI9L13MvbxlM0qI4DKy2FCdhjOWvvKNfohqw==;20:dzv0yUkxOJv4Muj/eY4zx/EJG3MmffDjovLq2WV4VynzaOZUsAJnR7Vd7Kq1Ho32SZ7krrpwy79xzCskvI0n0J1Ht0dEYDfi52B2LTfH2I0Xl7r0W0rVCRwnsDRJKMn1S4b7hY7LAszPuAkSQcCIa7JAi1q0FmFD0WKK3lU79RA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0771; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:AM2PR02MB0771;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0771; X-Microsoft-Exchange-Diagnostics: 1;AM2PR02MB0771;4:8lt6BJ2paTcwVP4WdmFgVm0NRIxRpl3o4gan6r1jOVSTfQNL595vFEXwcz9KUHnZ6B65cI12UHxiNRQh3Zk40jlqAFj81Sj4f9DtGiYFQOmmSd6u0EuLK45e3dBbEJu1wXJ7TT7dvyJ4/yK4jOUwMNLc78sx8ZstGALImnS0I5GEA5rae2ciFcSca5elM/RRsPrBi/ULcMfZzW0S+/KCbgUvDWtji8WF0eTxDs4BNOEDPM0FGdOASBb0AuFgYxcutxoB9qZoOKJrq6EZCJxCMS2EcoWYwlF6D6xatW+Nps1LtVEdPXAGv+uUz4v1jjXjVJ5/6WYH2ZJAfWLhaPw3wL5rcmAS6ju3Lguh/8ADdKg= X-Forefront-PRVS: 0722981D2A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(189002)(479174004)(24454002)(199003)(377454003)(101416001)(87976001)(66066001)(42186005)(83506001)(50986999)(76176999)(65956001)(33656002)(40100003)(575784001)(106356001)(105586002)(23746002)(54356999)(65816999)(47776003)(77096005)(65806001)(64126003)(64706001)(86362001)(122386002)(97736004)(36756003)(5001920100001)(5007970100001)(5008740100001)(81156007)(5004730100002)(19580405001)(19580395003)(15975445007)(4001350100001)(110136002)(5001960100002)(92566002)(50466002)(2950100001)(46102003)(230783001)(189998001)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR02MB0771;H:[10.7.0.41];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM2PR02MB0771;23:FPLNru9cNq3IEXtHfZ7S4h1AZRbaqsApY404z?= =?Windows-1252?Q?Q7J267JbvC6cH7Eb8NBX3QtKj71FGCsk6ZUjpvOXTJ9UEP1e7E6EWEfi?= =?Windows-1252?Q?BQr/LywM5Z4EPH7I9dRSzgm5BsYGr7UzRbtIeIIbKxO3nnQZ7Q/Ds+od?= =?Windows-1252?Q?n39P371t+rgLuXro06aT795pA2S/7PTCHWe/Ry1yRYKpJnoZusX7pjtZ?= =?Windows-1252?Q?4y+lgKr7C/xDPZ6OutIGkTgAfr5Qg78j0IqDisfoxbNHBZZEHq3VA7+3?= =?Windows-1252?Q?T9pP3Jb/n9pDtJzWlZkv6O2rcV5KeSyMKOiWUMg9+YGZIhzfd/7z1QVT?= =?Windows-1252?Q?nSSQX/gbEDW0FVRAiV628xr0xi1cIdCNGFSvw6A7tS04Hew3NygxQLvM?= =?Windows-1252?Q?SDVn15ZRHWXBMdHZKdZpo0ucWp0f9CWn2vXJDbFlMjm26yLDL4Rvu0ai?= =?Windows-1252?Q?gyCeA+zrshi/vV992MAlvv42iQ4tljMIhRWNsb/XhRxzATcwGIrhHmew?= =?Windows-1252?Q?FgCqbTeXSomtF5fG3MQFJwnk/z/84hAZPI4DZEjJpzjBe9IzRvYmsrwX?= =?Windows-1252?Q?Y8jO10P5x0EVXQB2KtsPro3YkA7Zv4YexZEI4oR4N/wwfZ0nk2/9Srvk?= =?Windows-1252?Q?bmnZos82IEqSorOYHy0jeDTKQu/nuqlQJItjS1UEPWR+e+6NpvMF/CZT?= =?Windows-1252?Q?lxu2htIQ7gffRzkdVOv6HkBvjM/1sTPMWBGCRNcaA1uwJGUINP5kur2h?= =?Windows-1252?Q?ziH/xwK5D4S7qX1Jv/Kt2FaR2ay5uA73Lqa8k9N3NsoN3egY6XeOjrPq?= =?Windows-1252?Q?CgVSNGrWtFBFXLXdUh8cKmARPicUfrdKVJbpskXpDnNDAKnb9xjHD1xn?= =?Windows-1252?Q?i4ET5w3P11cowsnntD/jJgwvJm2WqF9168ew1pWPmmxpN69c6/dPQVkO?= =?Windows-1252?Q?gvOiQWxjYHxBzsZuVrAqpWirZq4phOd/lOadJnG9yIxoKhr/0fU1hoip?= =?Windows-1252?Q?8gI6Oag5qFI8EeBjiPOrDHlfBohFTL6kcZH5Z8En5d5RPMD4laXYJ7/1?= =?Windows-1252?Q?rgKY5tfhCXoavgSiwcZzuTgQupu5plk4zAzVM9JD4AeGwS88C7aNSo2F?= =?Windows-1252?Q?CT0g+TSHdQL+dky2B0oa4HAxBZO2Uc1PCC7WOpKEqNA1J6j+qf+mKftY?= =?Windows-1252?Q?fyuMqAcVa82Q74kpKh/37rus4OjMeRGjNJxgV8bGAqx9cgRBjIjrgn+C?= =?Windows-1252?Q?QKaSlgpVVuGPNwAopDqTDWY5GolJ+S8WmCkplpFAok0TgUuuHhS6CWtG?= =?Windows-1252?Q?OAm+LJB+PDNsAfFJVtve8v37C7mMG2sqZ87H8Sv7Wqy28GlTqhmHSWPS?= =?Windows-1252?Q?WdfYlq5Q9hl6otdMK5DcUv03LYnBg2pcjeGZuW8VpfFIQHmDzouHnOEK?= =?Windows-1252?Q?VTjgvNkZ6x4rlNWZ9kD?= X-Microsoft-Exchange-Diagnostics: 1;AM2PR02MB0771;5:uJVqkSyN067XNuwoHc5Ck41OP+emX77lPR+h0BkRACgLg+EWAkC8N97zuLvORz93RInQsYvdenkMIXV6+NdgYWtaGfTpB15tiTnItNxi0DQ5HBKdPICiMpysV2OSx/dYdaluoga/83bGUiAWKjhh7A==;24:ngjHI9WP0oMdFy/93GWZqkT4Kcc51Qw5oJ/QoUrWRSVIFEsUeehc1eF8np60z+ppzkFUzCiG1tTVHrTcGRWsFOpI8zKShX8Gjc8lvf1kf8s=;20:VO6V+5fQl//rjEwJkqmpJUZ1qIuCx7Bwf61nifHKcHB9Cz1FshWoGBY/EiMDAEpCa0R4dsmZRClDSs4pr2HqeQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2015 13:58:36.1014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR02MB0771 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2015 01:53 AM, Ingo Molnar wrote: > * Chris Metcalf wrote: > >> Both alpha and tile needed implementations of zero_bytemask. >> >> The alpha version is untested. >> >> Signed-off-by: Chris Metcalf >> --- >> arch/alpha/include/asm/word-at-a-time.h | 2 ++ >> arch/tile/include/asm/word-at-a-time.h | 8 +++++++- >> 2 files changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/arch/alpha/include/asm/word-at-a-time.h b/arch/alpha/include/asm/word-at-a-time.h >> index 6b340d0f1521..902e6ab00a06 100644 >> --- a/arch/alpha/include/asm/word-at-a-time.h >> +++ b/arch/alpha/include/asm/word-at-a-time.h >> @@ -52,4 +52,6 @@ static inline unsigned long find_zero(unsigned long bits) >> #endif >> } >> >> +#define zero_bytemask(mask) ((2ul << (find_zero(mask) * 8)) - 1) > Small nit: please use a proper C inline function instead of CPP, as for example > the PowerPC zero_bytemask() function is. Indeed, I normally would do that. But, I was trying to match the existing style; there are nine definitions that are specified as macros (including the one in asm-generic), and only one (powerpc 64-bit LE) that was specified as an inline. I did put together a v3 of the patch series that included all your excellent suggestions, including the Reported-by, Tested-by, and Reviewed-by tags, but then found out v2 was already pulled into Linus's tree, so I guess that ship has sailed; oh well. My inclination would be not to churn the tree with a patch to convert those new zero_bytemask() macros to inlines, but I'm happy to do so if you think it would be better. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com