* [PATCH] xen/balloon: Use the correct sizeof when declaring frame_list
@ 2015-10-07 13:04 Julien Grall
2015-10-07 16:15 ` [Xen-devel] " David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2015-10-07 13:04 UTC (permalink / raw)
To: xen-devel
Cc: ian.campbell, linux-kernel, Julien Grall, Konrad Rzeszutek Wilk,
Boris Ostrovsky, David Vrabel
The type of the item in frame_list is xen_pfn_t which is not an unsigned
long on ARM but an uint64_t.
With the current computation, the size of frame_list will be 2 *
PAGE_SIZE rather than PAGE_SIZE.
I bet it's just mistake when the type has been switched from "unsigned
long" to "xen_pfn_t" in commit 965c0aaafe3e75d4e65cd4ec862915869bde3abd
"xen: balloon: use correct type for frame_list".
Signed-off-by: Julien Grall <julien.grall@citrix.com>
----
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
---
drivers/xen/balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index b50d229..12eab50 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -141,7 +141,7 @@ struct balloon_stats balloon_stats;
EXPORT_SYMBOL_GPL(balloon_stats);
/* We increase/decrease in batches which fit in a page */
-static xen_pfn_t frame_list[PAGE_SIZE / sizeof(unsigned long)];
+static xen_pfn_t frame_list[PAGE_SIZE / sizeof(xen_pfn_t)];
/* List of ballooned pages, threaded through the mem_map array. */
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Xen-devel] [PATCH] xen/balloon: Use the correct sizeof when declaring frame_list
2015-10-07 13:04 [PATCH] xen/balloon: Use the correct sizeof when declaring frame_list Julien Grall
@ 2015-10-07 16:15 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2015-10-07 16:15 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: ian.campbell, linux-kernel, David Vrabel, Boris Ostrovsky
On 07/10/15 14:04, Julien Grall wrote:
> The type of the item in frame_list is xen_pfn_t which is not an unsigned
> long on ARM but an uint64_t.
Applied to for-linus-4.4, thanks.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-07 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-07 13:04 [PATCH] xen/balloon: Use the correct sizeof when declaring frame_list Julien Grall
2015-10-07 16:15 ` [Xen-devel] " David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).