From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753706AbbJGTTM (ORCPT <rfc822;w@1wt.eu>);
	Wed, 7 Oct 2015 15:19:12 -0400
Received: from bear.ext.ti.com ([192.94.94.41]:37051 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751543AbbJGTTK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 7 Oct 2015 15:19:10 -0400
Subject: Re: [PATCH] genirq: export handle_bad_irq
To: Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>
References: <5847725.4IBopItaOr@wuerfel>
CC: <linux-kernel@vger.kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Austin Schuh <austin@peloton-tech.com>,
        Tony Lindgren <tony@atomide.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-gpio@vger.kernel.org>,
        <linux-omap@vger.kernel.org>
From: Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <56157000.4010009@ti.com>
Date: Wed, 7 Oct 2015 14:18:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <5847725.4IBopItaOr@wuerfel>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On 10/06/2015 03:24 PM, Arnd Bergmann wrote:
> A cleanup of the omap gpio driver introduced a use of the
> handle_bad_irq() function in a device driver that can be
> a loadable module.
>
> This broke the ARM allmodconfig build:
>
> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>
> This patch exports the handle_bad_irq symbol in order to
> allow the use in modules.
>

Thanks for fixing it and sorry for the mess.
Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>


> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index ea7b5fd99ba5..142bbf3b607f 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
>   	kstat_incr_irqs_this_cpu(desc);
>   	ack_bad_irq(irq);
>   }
> +EXPORT_SYMBOL_GPL(handle_bad_irq);
>
>   /*
>    * Special, empty irq handler:
>


-- 
regards,
-grygorii