From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753895AbbJGTTT (ORCPT ); Wed, 7 Oct 2015 15:19:19 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:44379 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbbJGTTQ (ORCPT ); Wed, 7 Oct 2015 15:19:16 -0400 Subject: Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate To: Sudip Mukherjee , Arnd Bergmann References: <1444132871-25798-1-git-send-email-sudipm.mukherjee@gmail.com> <561432D3.20709@ti.com> <20151007072743.GB21158@sudip-pc> CC: Linus Walleij , Alexandre Courbot , , , Tony Lindgren , Austin Schuh , Santosh Shilimkar From: Grygorii Strashko Message-ID: <56157024.1070905@ti.com> Date: Wed, 7 Oct 2015 14:19:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151007072743.GB21158@sudip-pc> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2015 02:27 AM, Sudip Mukherjee wrote: > On Tue, Oct 06, 2015 at 03:45:07PM -0500, Grygorii Strashko wrote: >> On 10/06/2015 07:01 AM, Sudip Mukherjee wrote: >>> While building arm allmodconfig the build fails with the error: >>> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined! >>> >>> The build breaks as handle_bad_irq is not exported for module use. >> >> Not sure if this is right thing to do. We really want it to be a module if needed. >> >> The handle_bad_irq() was used in this driver to catch the case when Omap >> GPIO IRQ is enabled before calling .irq_set_type() >> >> I think there are few option: >> - export handle_bad_irq() >> - pass NULL in gpiochip_irqchip_add() instead of handle_bad_irq() >> - use handle_simple_irq() >> - revert this change >> >> Thought second one should work. > > I think that should be ok. If you want me to test the patch in my setup > to verify that it fixes the build failure please let me know. > > But going through the old thread it looked like plan was on to > export handle_bad_irq() atleast thats what looks like from Linus's > (Linus Walleij) reply in https://lkml.org/lkml/2014/2/25/119 There is patch from Arnd which implements option one. https://lkml.org/lkml/2015/10/6/836 -- regards, -grygorii