From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754136AbbJGUmJ (ORCPT ); Wed, 7 Oct 2015 16:42:09 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:4551 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752649AbbJGUmH (ORCPT ); Wed, 7 Oct 2015 16:42:07 -0400 Subject: Re: [GIT PULL] (xen) for-jens-4.3 for your 'for-4.3/drivers' branch To: Konrad Rzeszutek Wilk References: <20151007192623.GB23861@l.oracle.com> <5615781D.4020506@fb.com> <20151007203228.GB6997@l.oracle.com> CC: , From: Jens Axboe Message-ID: <561581CE.503@fb.com> Date: Wed, 7 Oct 2015 14:34:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151007203228.GB6997@l.oracle.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-10-07_11:2015-10-07,2015-10-07,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2015 02:32 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Oct 07, 2015 at 01:53:01PM -0600, Jens Axboe wrote: >> On 10/07/2015 01:26 PM, Konrad Rzeszutek Wilk wrote: >>> Hey Jens, >>> >>> Please git pull an update branch to your 'for-4.3/drivers' branch (which >>> oddly I don't see does not have the previous pull?) >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-jens-4.3 >>> >>> which has two fixes - one where we use the Xen blockfront EFI driver and >>> don't release all the requests, the other if the allocation of resources >>> for a particular state failed - we would go back 'Closing' and assume that >>> an structure would be allocated while in fact it may not be - and crash. >>> >>> Please pull! >>> >>> P.S. >>> The patches also have 'stable@vger.kernel.org' on them. >>> >>> drivers/block/xen-blkback/xenbus.c | 38 ++++++++++++++++++++------------------ >>> drivers/block/xen-blkfront.c | 3 ++- >>> 2 files changed, 22 insertions(+), 19 deletions(-) >>> >>> Cathy Avery (1): >>> xen-blkfront: check for null drvdata in blkback_changed (XenbusStateClosing) >>> >>> Roger Pau Monne (1): >>> xen/blkback: free requests on disconnection >> >> There's only one commit in that pull request, the patch from Roger is >> already in mainline from the last pull request. I think your mistake is > > Hm, indeed I see it now (after doing git pull from non-work machine). > >> looking at for-4.3/drivers - this branch is defunct as soon as Linus has >> pulled the initial bits for 4.3. After that, for-linus is the branch that >> carries fixes for the _current_ branch. > > Aaaa! That I had no clue about. OK, I will fix my workflow. Do you want > me to repost this basing it on the 'for-linus' branch? No the current one is fine, it's only a concern if there are other changes in your branch compared to mine. I just got a different diffstat for this one than you listed, so I had to check it more thoroughly. I have pulled it in. -- Jens Axboe