From: Hans de Goede <hdegoede@redhat.com>
To: monnier@iro.umontreal.ca, linux-sunxi@googlegroups.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-sunxi] Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi
Date: Thu, 8 Oct 2015 09:32:40 +0100 [thread overview]
Message-ID: <56162A28.8000104@redhat.com> (raw)
In-Reply-To: <jwvegh6d60k.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
Hi,
On 10/07/2015 05:01 PM, Stefan Monnier wrote:
>> @Maxime: How should we handle this? In its current form, the patch applies
>> only to the BananaPi dts by overriding the inherited opp from the SoC dtsi.
>> In an earlier discussion, it was said that this can be done, even though it
>> might not be the most elegant approach. But then again, I think it
>> shouldn't be necessary to change the opp in the sun7i-a20.dtsi for all A20
>> boards since this is - to my knowledge - the first and only report that an
>> A20 board has stability issues at the lower voltages (although not too many
>> boards use voltage scaling yet).
>
> IIUC this setting doesn't affect signals external to the A20, so it
> seems like it should be board-agnostic.
This setting configures the voltage at the pmic output pin, not at the SoC
power-input pins. And how much of the voltage actually makes it from the pmic
to the SoC definitely is board-specific. So we are going to need board-specific
opp-s in some cases (like this one for example).
Regards,
Hans
prev parent reply other threads:[~2015-10-08 8:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 16:18 [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi Timo Sigurdsson
2015-08-03 9:47 ` Maxime Ripard
2015-08-03 13:11 ` [linux-sunxi] " Hans de Goede
2015-08-18 15:33 ` Maxime Ripard
2015-08-04 9:02 ` Timo Sigurdsson
2015-08-18 15:32 ` Maxime Ripard
2015-08-08 15:35 ` [linux-sunxi] " Hans de Goede
2015-08-18 15:36 ` Maxime Ripard
2015-09-24 17:57 ` Kevin Hilman
2015-09-25 15:05 ` Timo Sigurdsson
2015-09-27 8:20 ` Maxime Ripard
2015-10-05 17:39 ` Timo Sigurdsson
2015-10-07 9:44 ` Maxime Ripard
2015-10-07 14:36 ` Kevin Hilman
2015-10-07 15:49 ` Timo Sigurdsson
2015-10-07 17:49 ` Maxime Ripard
2015-10-07 17:58 ` Timo Sigurdsson
[not found] ` <jwvegh6d60k.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2015-10-08 8:32 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56162A28.8000104@redhat.com \
--to=hdegoede@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).