From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Roman Alyautdin <ralyautdin@dev.rtsoft.ru>, balbi@ti.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: dsps: implement vbus_status method
Date: Thu, 8 Oct 2015 16:50:49 +0300 [thread overview]
Message-ID: <561674B9.1040101@cogentembedded.com> (raw)
In-Reply-To: <1444228816-4497-1-git-send-email-ralyautdin@dev.rtsoft.ru>
Hello.
On 10/7/2015 5:40 PM, Roman Alyautdin wrote:
> Implement vbus_status method of musb_platform_ops that allows
> musb_core to properly represent the VBUS status of musb_dsps devices in
> corresponding sysfs entry
>
> Signed-off-by: Roman Alyautdin <ralyautdin@dev.rtsoft.ru>
> ---
> drivers/usb/musb/musb_dsps.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index 84512d1..9c00edf 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -632,6 +632,18 @@ static void dsps_read_fifo32(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
> }
> }
>
> +static int dsps_musb_vbus_status(struct musb *musb)
> +{
> + void __iomem *mregs = musb->mregs;
> + u8 devctl;
> +
> + devctl = dsps_readb(mregs, MUSB_DEVCTL);
> + if ((devctl & MUSB_DEVCTL_VBUS) == (3 << MUSB_DEVCTL_VBUS_SHIFT))
I don't see why this has to be is implemented in the DSPS glue layer. The
DevCtl register is a standard MUSB one.
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-10-08 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 14:40 [PATCH] usb: musb: dsps: implement vbus_status method Roman Alyautdin
2015-10-08 13:50 ` Sergei Shtylyov [this message]
2015-10-08 14:07 ` Sergei Shtylyov
2015-10-08 14:27 ` Roman Alyautdin
2015-10-09 21:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561674B9.1040101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ralyautdin@dev.rtsoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox