Re: [PATCH 1/3] media: rockchip: Introduce the rkvdec2 driver

Piotr Oniszczuk
2025-01-30T10:46:23Z

> Wiadomość napisana przez Detlev Casanova <detlev.casanova@collabora.com> w dniu 29 sty 2025, o godz. 17:50:
>
> Hi Piotr,
>
> On Wednesday, 29 January 2025 09:48:51 EST Piotr Oniszczuk wrote:
>
> I suppose you tested with my hevc branch, which is not really ready yet (Some
> ref frames will work but usually, it won't) Can you confirm which branch/commit
> you based your tests on ?

Indeed - i’m using your rkvdec2 hevc code from: https://gitlab.collabora.com/detlev/linux/-/commits/add-rkvdec2-driver-hevc with iommu from https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/commit/bc47c445bfd9586115e9bcf5f231c5a5c5f0f828
and https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/commit/9a9fd791513bc0d02c2242c88f23b41bd47de30a

>
> For the iommu, do you see those errors like that only on 356x or also on 3588
> ?

3588 has no any iommu errors.
I see iommu errors only on 356x

> The hevc branch should have the iommu patches to fix that kind of things.

I’m using:
https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/commit/bc47c445bfd9586115e9bcf5f231c5a5c5f0f828
https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/commit/9a9fd791513bc0d02c2242c88f23b41bd47de30a

I see there is: https://gitlab.collabora.com/detlev/linux/-/commits/add-rkvdec2-driver-iommu
Let me update iommu code to above branch and report back here how it goes in 3588 and 356x

>
> (but note that hevc support is really new, so it may have bugs with buffer
> allocations)

It is already great work.
I’m awaiting for hevc in 35xx during last 2+ years :-)

>
>> If anybody hints me for way/tool to analyse of playing/failing samples to
>> catch: what encoding specifics makes given sample failing to decode on
>> rkvdec2 - i'll be more that happy to provide details… (doing simple
>> mediainfo <file> shows no differences for me…)
>
> Few features are supported for HEVC as of now:
> - No scanlist support (only default 16x16 blocks will work)
> - Long term reference frames are also not configured yet.
> - hevc 10 bits is also not supported yet
>
> These are specific to the encoding and mediainfo won't really give you
> information on that, except maybe on the 10 bits format.
>
> You can also checkout YUView (https://github.com/IENT/YUView) to get
> information on media files structure, but I have had issues with HEVC support
> lately.

oh great. will do and report!