From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CD3C43143 for ; Mon, 1 Oct 2018 20:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41D702084C for ; Mon, 1 Oct 2018 20:03:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="YNoT2R+T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D702084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbeJBCm5 (ORCPT ); Mon, 1 Oct 2018 22:42:57 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:51844 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbeJBCm5 (ORCPT ); Mon, 1 Oct 2018 22:42:57 -0400 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 52C2D5C0172; Mon, 1 Oct 2018 22:03:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1538424208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kSGCg2NQwBUgoZQEZeuf3kgRarYbEWK6dyFbj4d5MNs=; b=YNoT2R+TeE3QK56DhKVke28Nbu1GECXDQgXed1CJ61JbKaWWlZdQ0BzVHZ+0hn/xzCbTwY qHBWlN1WsCzVY1VT3NDNw6zfPEWxgDxdn/gpcBKUQmM5MnrUYc8m3I+0G0ki8jWW6HDXVH ooSj33FLpVL6v+JAJBwVsnaiU/z7NVM= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 01 Oct 2018 22:03:28 +0200 From: Stefan Agner To: Stefan Agner Cc: alison.wang@nxp.com, airlied@linux.ie, Madhur Verma , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hemanshu Srivastava , Satendra Singh Thakur , Daniel Vetter Subject: Re: [PATCH 2/2] drm/fsl-dcu: use drm_display_mode_to_videomode to calculate timing parameters In-Reply-To: <20181001075702.GS11082@phenom.ffwll.local> References: <20180926204150.29829-1-stefan@agner.ch> <20180926204150.29829-2-stefan@agner.ch> <20181001075702.GS11082@phenom.ffwll.local> Message-ID: <56170905672e17e6bd9bf0ef45c10ef6@agner.ch> X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.10.2018 09:57, Daniel Vetter wrote: > On Wed, Sep 26, 2018 at 10:41:50PM +0200, Stefan Agner wrote: >> From: Satendra Singh Thakur >> >> Use the drm_display_mode_to_videomode function to calculate front/ >> back porches and sync length. >> >> Cc: Madhur Verma >> Cc: Hemanshu Srivastava >> Signed-off-by: Satendra Singh Thakur >> Signed-off-by: Stefan Agner > > I think if lots of people want this (iirc yours not the only driver that > wants front/back-porch) we should extend the computed crtc_* fields with > this. Kinda silly we force people to go through v4l videomode in drm > drivers. But then, this gets the job done, so maybe an idea for todo.rst? Hm, I see, yeah seems rather straight forward to calculate this information in drm_mode_set_crtcinfo(). > > On both patches: > > Acked-by: Daniel Vetter Thanks, applied both. -- Stefan >> --- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 32 ++++++++++------------ >> 1 file changed, 14 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c >> index 05d1c9977395..18afc94e4dff 100644 >> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c >> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include