From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933256AbbJIIIW (ORCPT ); Fri, 9 Oct 2015 04:08:22 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:33661 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756015AbbJIIIP (ORCPT ); Fri, 9 Oct 2015 04:08:15 -0400 X-AuditID: cbfec7f5-f794b6d000001495-dc-561775ed5158 Message-id: <561775EC.80703@samsung.com> Date: Fri, 09 Oct 2015 10:08:12 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, sakari.ailus@linux.intel.com Subject: Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting References: <1442845770-17800-1-git-send-email-j.anaszewski@samsung.com> <1442845770-17800-2-git-send-email-j.anaszewski@samsung.com> <20151008155036.GF11776@xo-6d-61-c0.localdomain> <56175E9C.5040403@samsung.com> <20151009070202.GA27183@amd> In-reply-to: <20151009070202.GA27183@amd> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t/xy7pvS8XDDHbdEbc4f/cQs8XlXXPY LLa+WcdocffUUTaLT1u+MTmwesw7Geixc8dnJo8Vq7+ze3zeJBfAEsVlk5Kak1mWWqRvl8CV 8Xl2K1vBZbaKBSteMjUwbmPtYuTgkBAwkZi7wqSLkRPIFJO4cG89WxcjF4eQwFJGia/P3zBC OM8YJY4t2MMGUsUroCHRt/sXE0gzi4CqxNTX0iBhNgFDiZ8vXjOB2KICERJ/Tu9jhSgXlPgx +R4LiC0iIC+xtW8FM4jNLJAjcfLGLrC4sECcxMXVO5khdv1glLj9ZzrYLk4BTYmJR7YyQTRY S6yctI0RwpaX2LzmLfMERoFZSHbMQlI2C0nZAkbmVYyiqaXJBcVJ6blGesWJucWleel6yfm5 mxghQfx1B+PSY1aHGAU4GJV4eC2ixMOEWBPLiitzDzFKcDArifBaZwCFeFMSK6tSi/Lji0pz UosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwDhJnpN9oVfVQfN2X/bbCznd7U/8 unxKKKae7UrFNAn7Y+d1Ikq5lMvN/z1tjVD6foJ7kk+X5H5em3RBEZNVT/aesJwh2fzx0Qmx qi18Rmd+hHF21k75+fzB7u+JMktbOm51/lrX5/FDTG7+SwmjpHmOyUUL0rScyrO1IphFhA/9 /jRF+X/1DCWW4oxEQy3mouJEAD32XrJeAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2015 09:02 AM, Pavel Machek wrote: > On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote: >> On 10/08/2015 05:50 PM, Pavel Machek wrote: >>> On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote: >>>> This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags. >> >> s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/ >> >>>> led_set_brightness now calls led_set_brightness_nosleep instead of >>>> choosing between sync and async op basing on the flags defined by the >>>> driver. >>> >>> Are those flags unused in the version of kernel you are patching? >> >> The flags are used until this patch. > > Hmm. I seen you removing the definitions, but not removing any > users. I guess I missed something. Only LED core is the user. It sets SET_BRIGHTNESS_SYNC flag for LED flash class drivers. -- Best Regards, Jacek Anaszewski