From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933541AbbJIIUF (ORCPT ); Fri, 9 Oct 2015 04:20:05 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:33346 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933502AbbJIIT5 (ORCPT ); Fri, 9 Oct 2015 04:19:57 -0400 X-AuditID: cbfec7f5-f794b6d000001495-c6-561778ab0434 Message-id: <561778A4.3020006@samsung.com> Date: Fri, 09 Oct 2015 10:19:48 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, sakari.ailus@linux.intel.com, andrew@lunn.ch, rpurdie@rpsys.net Subject: Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently References: <1443445641-9529-1-git-send-email-j.anaszewski@samsung.com> <1443445641-9529-2-git-send-email-j.anaszewski@samsung.com> <56095923.7090600@samsung.com> <20151008155107.GJ11776@xo-6d-61-c0.localdomain> In-reply-to: <20151008155107.GJ11776@xo-6d-61-c0.localdomain> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t/xK7qrK8TDDB4u4LM4f/cQs8XlXXPY LLa+WcdocffUUTaL3bueslp82vKNyYHNY97JQI+dOz4zeeyZ/4PVY8Xq7+wenzfJBbBGcdmk pOZklqUW6dslcGUseLSKqeAja8XO9U+ZGhgfs3QxcnJICJhIHFnzmxXCFpO4cG89G4gtJLCU UWLh0goI+xmjRNdvfxCbV0BL4nnXO7BeFgFViVvzNzCD2GwChhI/X7xmArFFBSIk/pzexwpR LyjxY/I9sHoRAXmJrX0rwOqZBeolNu2D2CUs4COxats2xi5GLqBd1xklXp85yg6S4BSwlfj0 aQU7RIO1xMpJIEUgtrzE5jVvmScwCsxCsmMWkrJZSMoWMDKvYhRNLU0uKE5KzzXSK07MLS7N S9dLzs/dxAgJ7K87GJceszrEKMDBqMTDaxElHibEmlhWXJl7iFGCg1lJhNc6AyjEm5JYWZVa lB9fVJqTWnyIUZqDRUmcd+au9yFCAumJJanZqakFqUUwWSYOTqkGxoTuPt0tDetvnz7AfUCt 5mLxmqvT7r3+aj1HK8Ne5YDlyj2ZG1xiapwfsiVtVlhostloilnx14J9Yvef96+Um3lJj8Vs W7Pryc3m/1L+zFoelXDTQvRjwTVlvczUKRfTZ8j6q7VJH/N4rMGtrbAiWUdHkkHqBLu9z6Kj Dz9WrxPp+vlz5i3JjUosxRmJhlrMRcWJAJRCgDRoAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2015 05:51 PM, Pavel Machek wrote: > On Mon 2015-09-28 17:13:39, Jacek Anaszewski wrote: >> This patch isn't going to be applied since it can cause >> legal implications for existing users. >> > > Are there any? Best do this ASAP :-). Current non-GPL users of led_set_brightness would be affected if we changed this. I am not however certain if there are any, having in mind that led_classdev_register is exported with EXPORT_SYMBOL_GPL. Theoretically it is possible to use led_set_brightness without registering LED class device, but it would be partially broken then due to not initialized set_brightness_work. I think that it would be safe to apply this patch. I need acks, though :) -- Best Regards, Jacek Anaszewski