From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756855AbbJIOx4 (ORCPT ); Fri, 9 Oct 2015 10:53:56 -0400 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:57081 "EHLO e06smtp08.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755715AbbJIOxy (ORCPT ); Fri, 9 Oct 2015 10:53:54 -0400 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH] locktorture: fix wrong parameter handling To: paulmck@linux.vnet.ibm.com References: <1444392885-6691-1-git-send-email-borntraeger@de.ibm.com> <20151009144650.GR3910@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org From: Christian Borntraeger Message-ID: <5617D4FD.3030803@de.ibm.com> Date: Fri, 9 Oct 2015 16:53:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151009144650.GR3910@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15100914-0033-0000-0000-0000045D2209 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 09.10.2015 um 16:46 schrieb Paul E. McKenney: > On Fri, Oct 09, 2015 at 02:14:45PM +0200, Christian Borntraeger wrote: >> Calling locktorture with a wrong parameter makes it >> unusable: >> >> $ modprobe locktorture torture_type=help >> modprobe: ERROR: could not insert 'locktorture': Invalid argument >> >> $ modprobe locktorture torture_type=spin_lock >> modprobe: ERROR: could not insert 'locktorture': Device or resource busy >> >> $ dmesg >> [...] >> torture_init_begin: refusing spin_lock init: help running >> >> We can easily do the checking before call into the torture framework. >> >> Signed-off-by: Christian Borntraeger > > Good catch, thank you! > > Could you please port this to rcu/next in the -rcu tree? Also, please > capitalize the word following the ":" in the subject line, as in "[PATCH] > locktorture: Fix wrong parameter handling". Hmmm, seems that this is already fixed in rcu/next with commit a36a99618b1adb2d6ca0b7e08e3a656a04e477fe Author: Paul E. McKenney AuthorDate: Sun Aug 30 20:01:48 2015 -0700 Commit: Paul E. McKenney CommitDate: Tue Oct 6 11:28:44 2015 -0700 locktorture: Fix module unwind when bad torture_type specified No need to respin a patch it seems :-)