From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757055AbbJIPBe (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2015 11:01:34 -0400
Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:9630 "EHLO
	eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753037AbbJIPBd convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2015 11:01:33 -0400
Subject: Re: [PATCH v2 11/22] arm64: Populate cpuinfo after
 notify_cpu_starting
To: Catalin Marinas <catalin.marinas@arm.com>
References: <1444064531-25607-1-git-send-email-suzuki.poulose@arm.com>
 <1444064531-25607-12-git-send-email-suzuki.poulose@arm.com>
 <20151008101508.GE17192@e104818-lin.cambridge.arm.com>
 <56164972.3030906@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
        Vladimir.Murzin@arm.com, steve.capper@linaro.org,
        ard.biesheuvel@linaro.org, marc.zyngier@arm.com, will.deacon@arm.com,
        linux-kernel@vger.kernel.org, edward.nevill@linaro.org, aph@redhat.com,
        james.morse@arm.com, andre.przywara@arm.com, dave.martin@arm.com
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Message-ID: <5617D6C4.7030602@arm.com>
Date: Fri, 9 Oct 2015 16:01:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <56164972.3030906@arm.com>
X-OriginalArrivalTime: 09 Oct 2015 15:01:25.0080 (UTC) FILETIME=[5E058580:01D102A3]
X-MC-Unique: WzlvaAWLRXeHedbP4IZivA-1
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/10/15 11:46, Suzuki K. Poulose wrote:
> On 08/10/15 11:15, Catalin Marinas wrote:
>> On Mon, Oct 05, 2015 at 06:02:00PM +0100, Suzuki K. Poulose wrote:
>>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>>> index cb3e0d8..6987de4 100644
>>> --- a/arch/arm64/kernel/smp.c
>>> +++ b/arch/arm64/kernel/smp.c
>>> @@ -163,14 +163,14 @@ asmlinkage void secondary_start_kernel(void)
>>>           cpu_ops[cpu]->cpu_postboot();
>>>
>>>       /*
>>> -     * Log the CPU info before it is marked online and might get read.
>>> +     * Enable GIC and timers.
>>>        */
>>> -    cpuinfo_store_cpu();
>>> +    notify_cpu_starting(cpu);
>>>
>>>       /*
>>> -     * Enable GIC and timers.
>>> +     * Log the CPU info before it is marked online and might get read.
>>>        */
>>> -    notify_cpu_starting(cpu);
>>> +    cpuinfo_store_cpu();
>>>
>>>       smp_store_cpu_info(cpu);
>>
>> You can move the cpuinfo_store_cpu() call directly to
>> smp_store_cpu_info().
>>
>
> That looks better, Thanks.

On a second look, smp_store_cpu_info() is also called from
smp_prepare_cpus() by the Boot CPU to update its topology
information, just after init_cpu_topology(). So moving the
cpuinfo_store_cpu() could be called for the boot CPU (which
we don't want, as it takes a different route to storing the
info).

One thing we could do is:

- Move init_cpu_topology() to setup_processor()
- Have the boot CPU update the topology from setup_processor()
   there, without going via the smp_store_cpu_info()
- Remove the smp_store_cpu_info() from smp_prepare_cpus().

Should we do that ? Or retain the code as above ?

Suzuki