From: Casey Schaufler <casey@schaufler-ca.com>
To: Geliang Tang <geliangtang@163.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] smack: smk_ipv6_port_list should be static
Date: Fri, 9 Oct 2015 15:19:53 -0700 [thread overview]
Message-ID: <56183D89.50507@schaufler-ca.com> (raw)
In-Reply-To: <faabfe26bce5c9c3ee56527ed6c6007224a02ee6.1443366384.git.geliangtang@163.com>
On 9/27/2015 8:10 AM, Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/smack/smack_lsm.c:55:1: warning: symbol 'smk_ipv6_port_list'
> was not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Applied to https://github.com/cschaufler/smack-next.git#smack-for-4.4
> ---
> security/smack/smack_lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 996c889..f02438c 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -52,7 +52,7 @@
> #define SMK_SENDING 2
>
> #ifdef SMACK_IPV6_PORT_LABELING
> -LIST_HEAD(smk_ipv6_port_list);
> +static LIST_HEAD(smk_ipv6_port_list);
> #endif
> static struct kmem_cache *smack_inode_cache;
> int smack_enabled;
next prev parent reply other threads:[~2015-10-09 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 15:10 [PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang
2015-09-27 15:10 ` [PATCH 2/2] smack: smk_ipv6_port_list " Geliang Tang
2015-10-09 22:19 ` Casey Schaufler [this message]
2015-09-28 15:22 ` [PATCH 1/2] selinux: ioctl_has_perm " Jeffrey Vander Stoep
2015-09-29 20:28 ` Stephen Smalley
2015-09-30 17:11 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56183D89.50507@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=geliangtang@163.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox