From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757770AbbJIWTX (ORCPT ); Fri, 9 Oct 2015 18:19:23 -0400 Received: from smtp104.biz.mail.bf1.yahoo.com ([98.139.221.63]:47495 "EHLO smtp104.biz.mail.bf1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757742AbbJIWTV (ORCPT ); Fri, 9 Oct 2015 18:19:21 -0400 X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: r7a4CroVM1mXYp2kGyAyp_6hBrsDMnNzkYuPHKK_xkkakn2 bE2BhK4YSatU18qjxc4nWJbD9yIAuqFkQkFzEz2woecFH57l3dAqLlYe1qIU 84ukRyE35T_P.YvffbrAasSMLF4HXik.gkJtS92VDFrpykouVnmE_Wss2YMe DoWa6I39279DJFli6F.QDv4Ca4C6sgRgd50JlLNRcl00ogq1uzfO8DeTqfaQ f5Felatf_HdkKnyrp0KYJ3UbYAGch1HAEZs3eCOjU3gXF1_i3ZI37EMXQIeb PW4XpfDUJ8hEtog.olUXf4dQBCORqztX4XkUdWAolAwga_iRBFnH3UMoF4cm MHyfsK78lJBmBvJWbiJPT67.cLCqywAV5TeKS4CyVqwh0GhHycPQFTew.X1F 7XIT3XLsAl6cEpSCDryZOHPMRbzHqik4wKh7F4Ytjhi..ABXaqurTC28Ug1v a1RBQnlnf.zV6hraLKD9gA2Pqr7GJAZYLjUAhwvBobzJPYTMASQ319a7PhBi Beo1_MWdtvpYqpZBRy7RbITlUpEsiEcbXBDa7Ng9lgG3wUVuPztqOEDM- X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- Subject: Re: [PATCH 2/2] smack: smk_ipv6_port_list should be static To: Geliang Tang , James Morris , "Serge E. Hallyn" References: Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org From: Casey Schaufler Message-ID: <56183D89.50507@schaufler-ca.com> Date: Fri, 9 Oct 2015 15:19:53 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/2015 8:10 AM, Geliang Tang wrote: > Fixes the following sparse warning: > > security/smack/smack_lsm.c:55:1: warning: symbol 'smk_ipv6_port_list' > was not declared. Should it be static? > > Signed-off-by: Geliang Tang Acked-by: Casey Schaufler Applied to https://github.com/cschaufler/smack-next.git#smack-for-4.4 > --- > security/smack/smack_lsm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c > index 996c889..f02438c 100644 > --- a/security/smack/smack_lsm.c > +++ b/security/smack/smack_lsm.c > @@ -52,7 +52,7 @@ > #define SMK_SENDING 2 > > #ifdef SMACK_IPV6_PORT_LABELING > -LIST_HEAD(smk_ipv6_port_list); > +static LIST_HEAD(smk_ipv6_port_list); > #endif > static struct kmem_cache *smack_inode_cache; > int smack_enabled;