* [PATCH 2/2] smack: smk_ipv6_port_list should be static
2015-09-27 15:10 [PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang
@ 2015-09-27 15:10 ` Geliang Tang
2015-10-09 22:19 ` Casey Schaufler
2015-09-28 15:22 ` [PATCH 1/2] selinux: ioctl_has_perm " Jeffrey Vander Stoep
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Geliang Tang @ 2015-09-27 15:10 UTC (permalink / raw)
To: Casey Schaufler, James Morris, Serge E. Hallyn
Cc: Geliang Tang, linux-security-module, linux-kernel
Fixes the following sparse warning:
security/smack/smack_lsm.c:55:1: warning: symbol 'smk_ipv6_port_list'
was not declared. Should it be static?
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
security/smack/smack_lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 996c889..f02438c 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -52,7 +52,7 @@
#define SMK_SENDING 2
#ifdef SMACK_IPV6_PORT_LABELING
-LIST_HEAD(smk_ipv6_port_list);
+static LIST_HEAD(smk_ipv6_port_list);
#endif
static struct kmem_cache *smack_inode_cache;
int smack_enabled;
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] smack: smk_ipv6_port_list should be static
2015-09-27 15:10 ` [PATCH 2/2] smack: smk_ipv6_port_list " Geliang Tang
@ 2015-10-09 22:19 ` Casey Schaufler
0 siblings, 0 replies; 6+ messages in thread
From: Casey Schaufler @ 2015-10-09 22:19 UTC (permalink / raw)
To: Geliang Tang, James Morris, Serge E. Hallyn
Cc: linux-security-module, linux-kernel
On 9/27/2015 8:10 AM, Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/smack/smack_lsm.c:55:1: warning: symbol 'smk_ipv6_port_list'
> was not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Applied to https://github.com/cschaufler/smack-next.git#smack-for-4.4
> ---
> security/smack/smack_lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 996c889..f02438c 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -52,7 +52,7 @@
> #define SMK_SENDING 2
>
> #ifdef SMACK_IPV6_PORT_LABELING
> -LIST_HEAD(smk_ipv6_port_list);
> +static LIST_HEAD(smk_ipv6_port_list);
> #endif
> static struct kmem_cache *smack_inode_cache;
> int smack_enabled;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] selinux: ioctl_has_perm should be static
2015-09-27 15:10 [PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang
2015-09-27 15:10 ` [PATCH 2/2] smack: smk_ipv6_port_list " Geliang Tang
@ 2015-09-28 15:22 ` Jeffrey Vander Stoep
2015-09-29 20:28 ` Stephen Smalley
2015-09-30 17:11 ` Paul Moore
3 siblings, 0 replies; 6+ messages in thread
From: Jeffrey Vander Stoep @ 2015-09-28 15:22 UTC (permalink / raw)
To: Geliang Tang
Cc: Paul Moore, Stephen Smalley, Eric Paris, James Morris,
Serge E. Hallyn, linux-security-module, linux-kernel, SELinux
Acked-by: Jeff Vander Stoep <jeffv@google.com>
On Sun, Sep 27, 2015 at 8:10 AM, Geliang Tang <geliangtang@163.com> wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
> * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
> --
> 2.5.0
>
>
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] selinux: ioctl_has_perm should be static
2015-09-27 15:10 [PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang
2015-09-27 15:10 ` [PATCH 2/2] smack: smk_ipv6_port_list " Geliang Tang
2015-09-28 15:22 ` [PATCH 1/2] selinux: ioctl_has_perm " Jeffrey Vander Stoep
@ 2015-09-29 20:28 ` Stephen Smalley
2015-09-30 17:11 ` Paul Moore
3 siblings, 0 replies; 6+ messages in thread
From: Stephen Smalley @ 2015-09-29 20:28 UTC (permalink / raw)
To: Geliang Tang, Paul Moore, Eric Paris, James Morris,
Serge E. Hallyn
Cc: linux-security-module, linux-kernel, selinux
On 09/27/2015 11:10 AM, Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
> * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] selinux: ioctl_has_perm should be static
2015-09-27 15:10 [PATCH 1/2] selinux: ioctl_has_perm should be static Geliang Tang
` (2 preceding siblings ...)
2015-09-29 20:28 ` Stephen Smalley
@ 2015-09-30 17:11 ` Paul Moore
3 siblings, 0 replies; 6+ messages in thread
From: Paul Moore @ 2015-09-30 17:11 UTC (permalink / raw)
To: Geliang Tang
Cc: Stephen Smalley, Eric Paris, James Morris, Serge E. Hallyn,
selinux, linux-security-module, linux-kernel
On Sunday, September 27, 2015 11:10:24 PM Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file
> *file) * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread