From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753303AbbJIXS3 (ORCPT ); Fri, 9 Oct 2015 19:18:29 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:32941 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbbJIXSZ (ORCPT ); Fri, 9 Oct 2015 19:18:25 -0400 Subject: Re: [RFC PATCH 0/2] DRA72/DRA74: Add 2 lane support To: Bjorn Helgaas References: <1443445058-643-1-git-send-email-kishon@ti.com> <20151009225056.GD16112@localhost> <56184AE7.6060808@ti.com> CC: , , , , , , Arnd Bergmann , Rob Herring From: Kishon Vijay Abraham I Message-ID: <56184B3B.1050807@ti.com> Date: Sat, 10 Oct 2015 04:48:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56184AE7.6060808@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Saturday 10 October 2015 04:46 AM, Kishon Vijay Abraham I wrote: > Hi Bjorn, > > On Saturday 10 October 2015 04:20 AM, Bjorn Helgaas wrote: >> [+cc Arnd, Rob] >> >> On Mon, Sep 28, 2015 at 06:27:36PM +0530, Kishon Vijay Abraham I wrote: >>> Add driver modifications in pci-dra7xx to get x2 mode working in >>> DRA72 and DRA74. Certain modifications is needed in PHY driver also >>> which I'll send as a separate series. >>> >>> Kishon Vijay Abraham I (2): >>> pci: host: pci-dra7xx: use "num-lanes" property to find phy count >>> pci: host: pci-dra7xx: Enable x2 mode support >> >> Applied to pci/host-dra7xx for v4.4, thanks! >> >> I adjusted the subject line capitalization & format to match the history. >> >> Arnd, Rob, any comments on the DT updates or the "num-lanes" vs number of >> strings in "phy-names" changes? > > I sent it as RFC since I didn't have the board to test 2 lane mode with > $patch. And just now I got a board to test x2 and I found a problem with > the 2nd patch. > > .b1co_mode_sel_mask = GENMASK(2, 3), in the patch should be replaced with > .b1co_mode_sel_mask = GENMASK(3, 2). > > I'll resend the patch fixing the above. I'll resend after a couple of days to fix any comments from Arnd or Rob. Thanks Kishon > > Thanks > Kishon > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >