From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbbJJEhC (ORCPT ); Sat, 10 Oct 2015 00:37:02 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33830 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbbJJEgX (ORCPT ); Sat, 10 Oct 2015 00:36:23 -0400 Subject: Re: [PATCH] thermal: exynos: fix register read in TMU To: Lukasz Majewski References: <1443699599-9693-1-git-send-email-sudipm.mukherjee@gmail.com> <20151001141243.GA5061@sudip-pc> <20151008142129.GC10587@sudip-pc> <20151009140716.0c6e57b7@amdc2363> Cc: k.kozlowski.k@gmail.com, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Eduardo Valentin , Kukjin Kim , Zhang Rui , Sudip Mukherjee , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-ID: <561895C0.5030400@samsung.com> Date: Sat, 10 Oct 2015 13:36:16 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151009140716.0c6e57b7@amdc2363> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 09.10.2015 o 21:07, Lukasz Majewski pisze: > Hi Krzysztof, > >> 2015-10-08 23:21 GMT+09:00 Sudip Mukherjee >> : >>> On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote: >>>> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee >>>> : >>>>> On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski >>>>> wrote: >>>>>> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee >>>>>> : >>>>>>> The value of emul_con was getting overwritten if the selected >>>>>>> soc is SOC_ARCH_EXYNOS5260. And so as a result we were >>>>>>> reading from the wrong register in the case of >>>>>>> SOC_ARCH_EXYNOS5260. >>>>>> >>>>>> How the value is overwritten if the soc is Exynos5260? I can't >>>>>> see it (although the "else if" is still more obvious than "if" >>>>>> but how does the description match the code?). >>>>> The code here is: >>>>> if (data->soc == SOC_ARCH_EXYNOS5260) >>>>> emul_con = EXYNOS5260_EMUL_CON; >>>>> if (data->soc == SOC_ARCH_EXYNOS5433) >>>>> emul_con = EXYNOS5433_TMU_EMUL_CON; >>>>> else if (data->soc == SOC_ARCH_EXYNOS7) >>>>> emul_con = EXYNOS7_TMU_REG_EMUL_CON; >>>>> else >>>>> emul_con = EXYNOS_EMUL_CON; >>>>> >>>>> So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes >>>>> EXYNOS5260_EMUL_CON. But again for the else part it will become >>>>> EXYNOS_EMUL_CON. >>>> >>>> Indeed! >>>> >>>> Fixes: 488c7455d74c ("thermal: exynos: Add the support for >>>> Exynos5433 TMU") >>>> >>>> Reviewed-by: Krzysztof Kozlowski >>> >>> Hi Krzysztof, >>> Who will pick this one up? I still do not see it in linux-next. >> >> Hi! >> >> I guess it is a patch for Lukasz. >> >> Lukasz, >> Do you plan to pick it up or maybe this should go through samsung-soc >> tree? > > This is the only one patch, which is waiting in my queue. Since no more > fixes available, please feel free to grab this patch to samsung-soc. > > Acked-by: Lukasz Majewski Okay, thanks! Applied to fixes for current cycle. I'll it send later to Kukjin (unless he picks it as well). Best regards, Krzysztof