From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751380AbbJJGJH (ORCPT ); Sat, 10 Oct 2015 02:09:07 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35355 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbbJJGJD (ORCPT ); Sat, 10 Oct 2015 02:09:03 -0400 Subject: Re: [PATCH v2 3/4] i2c: s3c2410: enable RuntimePM before registering to the core To: Wolfram Sang , linux-sh@vger.kernel.org References: <1444383567-18113-1-git-send-email-wsa@the-dreams.de> <1444383567-18113-3-git-send-email-wsa@the-dreams.de> Cc: k.kozlowski.k@gmail.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kukjin Kim , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-ID: <5618AB74.2070001@samsung.com> Date: Sat, 10 Oct 2015 15:08:52 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444383567-18113-3-git-send-email-wsa@the-dreams.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 09.10.2015 o 18:39, Wolfram Sang pisze: > From: Wolfram Sang > > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-s3c2410.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index 50bfd8cef5f224..336e34e1ca597d 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -1243,19 +1243,21 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) > i2c->adap.nr = i2c->pdata->bus_num; > i2c->adap.dev.of_node = pdev->dev.of_node; > > + platform_set_drvdata(pdev, i2c); > + > + pm_runtime_enable(&pdev->dev); > + pm_runtime_enable(&i2c->adap.dev); > + > ret = i2c_add_numbered_adapter(&i2c->adap); > if (ret < 0) { > dev_err(&pdev->dev, "failed to add bus to i2c core\n"); > + pm_runtime_disable(&i2c->adap.dev); > + pm_runtime_disable(&pdev->dev); > s3c24xx_i2c_deregister_cpufreq(i2c); > clk_unprepare(i2c->clk); > return ret; > } > > - platform_set_drvdata(pdev, i2c); > - > - pm_runtime_enable(&pdev->dev); > - pm_runtime_enable(&i2c->adap.dev); > - > dev_info(&pdev->dev, "%s: S3C I2C adapter\n", dev_name(&i2c->adap.dev)); > return 0; > } > Hi, Unfortunately on Odroid XU3, Exynos5420, samsung,s3c2440-i2c, next-20151009-1-ga93b1a6f5055: [ 0.437678] s3c-i2c 12c80000.i2c: slave address 0x00 [ 0.437748] s3c-i2c 12c80000.i2c: bus frequency set to 65 KHz [ 0.438136] INFO: trying to register non-static key. [ 0.438180] the code is fine but needs lockdep annotation. [ 0.438225] turning off the locking correctness validator. [ 0.438277] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.3.0-rc4-next-20151009-00001-ga93b1a6f5055-dirty #237 [ 0.438353] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [ 0.438427] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 0.438512] [] (show_stack) from [] (dump_stack+0x70/0xbc) [ 0.438590] [] (dump_stack) from [] (__lock_acquire+0xa84/0xb18) [ 0.438667] [] (__lock_acquire) from [] (lock_acquire+0x70/0x90) [ 0.438746] [] (lock_acquire) from [] (_raw_spin_lock_irqsave+0x48/0x5c) [ 0.438830] [] (_raw_spin_lock_irqsave) from [] (pm_runtime_enable+0x14/0x5c) [ 0.438921] [] (pm_runtime_enable) from [] (s3c24xx_i2c_probe+0x450/0x5f0) [ 0.439006] [] (s3c24xx_i2c_probe) from [] (platform_drv_probe+0x50/0xac) [ 0.439086] [] (platform_drv_probe) from [] (driver_probe_device+0x1e0/0x418) [ 0.439165] [] (driver_probe_device) from [] (__driver_attach+0x94/0x98) [ 0.439250] [] (__driver_attach) from [] (bus_for_each_dev+0x54/0x88) [ 0.439332] [] (bus_for_each_dev) from [] (bus_add_driver+0x178/0x254) [ 0.439411] [] (bus_add_driver) from [] (driver_register+0x78/0xf4) [ 0.439488] [] (driver_register) from [] (do_one_initcall+0xb0/0x1f4) [ 0.439571] [] (do_one_initcall) from [] (kernel_init_freeable+0x11c/0x1e8) [ 0.439660] [] (kernel_init_freeable) from [] (kernel_init+0x8/0xec) [ 0.439740] [] (kernel_init) from [] (ret_from_fork+0x14/0x24) [ 0.439810] (null): Unbalanced pm_runtime_enable! [ 0.440965] s3c-i2c 12c80000.i2c: i2c-2: S3C I2C adapter The message appears after second pm_runtime_enable(). Next without the patch works. Best regards, Krzysztof