From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbbJJHrx (ORCPT ); Sat, 10 Oct 2015 03:47:53 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35845 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbbJJHrv (ORCPT ); Sat, 10 Oct 2015 03:47:51 -0400 Subject: Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core To: Wolfram Sang , linux-i2c@vger.kernel.org References: <1444461874-2841-1-git-send-email-wsa@the-dreams.de> Cc: k.kozlowski.k@gmail.com, Wolfram Sang , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-ID: <5618C2A1.2030101@samsung.com> Date: Sat, 10 Oct 2015 16:47:45 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444461874-2841-1-git-send-email-wsa@the-dreams.de> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 10.10.2015 o 16:24, Wolfram Sang pisze: > From: Wolfram Sang > > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. > > Signed-off-by: Wolfram Sang > --- > > Changes since v2: don't call runtime pm on adaper if it wasn't registered > > Thanks to Krzysztof for testing! > > drivers/i2c/busses/i2c-s3c2410.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Works good. Error path seems to be working fine as well. Tested on Odroid-XU3 Lite, on top of next-20151009. Tested-by: Krzysztof Kozlowski Best regards, Krzysztof