From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156AbbJLDwL (ORCPT ); Sun, 11 Oct 2015 23:52:11 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:54812 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbbJLDwI (ORCPT ); Sun, 11 Oct 2015 23:52:08 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-37-561b2e64e27f Subject: Re: [PATCH v6 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Rob Herring , joe@perches.com, Heiko Stuebner , Mark Yao References: <1444491357-26095-1-git-send-email-ykk@rock-chips.com> <1444491961-26799-1-git-send-email-ykk@rock-chips.com> <561B00D4.9060302@rock-chips.com> <561B0385.1070704@samsung.com> <561B1E65.1040806@rock-chips.com> Cc: Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <561B2E56.5020102@samsung.com> Date: Mon, 12 Oct 2015 12:51:50 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <561B1E65.1040806@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SaUjTcRjH+/2P3/5Kk19L84ddMOjSWkm9eIiIfPcnCnphEoOOf+6PhdNk y8giWheUeZVFNtMlzUpdKs5wdnhMMTrmwcpM8UizLDXLlklltjki332Pz/M8bx6BVV3jw4SD iYdlQ6KkV+NA7vmfJy/XyJqFMetyyxjoLG3moXykgIXMljcILI1e67pdj+FUjoWHl9/HMDx6 1cNA5kgBD+Ml5xQw3T/MQ/OnIgSXe7M4GBm1MXDXc10Bub0DHAz1tHEwPBQJmQPDLLQOpmFw nR5RQMVAOw/uBzcwjPdNs5DTUsNAl1sJjit1DGRdu8fBuceNCvgxMYGhu9yFICf7I4auX0HQ bMpWbFGLtnwbEs+eScNirqmNE90Z6Yw49eE1J1abuxVi0R0PFiuKL2Cx9+ITRrRbT4rpZz5j sTLTW3qK21lxylzLiRmVxUisas9nd6i0gZt0sv7gEdmwdvO+wAMtlkaUNBlytMm6w4TGSCoK ECjZQF2dTcivF9DWnjKcigIFFSlE9Nc7N+M3HkSrfzoZHzWf6GlHzruZIpjYWdr3pVbhp/oR /X7WNtOwxMnTU+nnWd8IJuup/Y4V+7SShNPCPvPMQY4so6cfTs/kIWQXvZRl4v3MPDqZ3cP5 dADR0NqOz95c8C7V0N62cF/MkqXUbhtlsxAxz5ow/6fMs6ibiC1GIXJybJJxf1xCpMYoJRiT E+M0sYcSKpD/XTwOdKtpoxMRAannKoXKsBgVLx0xpiQ4ERVYdbBSe8wbKXVSyjHZcGivIVkv G51oocCpQ5V5D8aiVSROOizHy3KSbPjXMkJAmAnl4dUWdcFVU9syxziV3xeV2PeorIvt7iGd VBmaen9FqjNIsYQej1pu6ZxzfWv/RO7uEDxa0hE9eP7EonisDWp4Gk4cNcz2t6tSBqyNH6q2 VT3jXkREzIvZLTXXIUf93a/aotKdaoPWXvrtR8OjPWL6b9fKaFNUcvRRPUnTTag54wEpMpw1 GKW/6ZDJQyoDAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.10.2015 11:43, Yakir Yang wrote: > > > On 10/12/2015 08:49 AM, Krzysztof Kozlowski wrote: >> On 12.10.2015 09:37, Yakir Yang wrote: >>> Hi Krzysztof, >>> >>> On 10/10/2015 11:46 PM, Yakir Yang wrote: >>>> Both hsync/vsync polarity and interlace mode can be parsed from >>>> drm display mode, and dynamic_range and ycbcr_coeff can be judge >>>> by the video code. >>>> >>>> But presumably Exynos still relies on the DT properties, so take >>>> good use of mode_fixup() in to achieve the compatibility hacks. >>>> >>>> Signed-off-by: Yakir Yang >>>> --- >>>> Changes in v6: None >>> + of_property_read_u32(dp_node, "hsync-active-high", >>> + &video->h_sync_polarity); >>> + of_property_read_u32(dp_node, "vsync-active-high", >>> + &video->v_sync_polarity); >>> + of_property_read_u32(dp_node, "interlaced", >>> + &video->interlaced); >>> +} >>> >>> >>> Sorry, forget to fix your previous comment here, would >>> remember to fix it to v7 version, wish v6 would collect >>> more comment/reviewed/ack. :) >> Right. >> >> You can send a v7 of only this patch. >> >> In the same time I would prefer not to chain-reply next version of >> entire patchset to cover letter of previous version. It confuses me >> because v6 appears UNDER v4 so I can't really find v6. I see v4 at the >> top of my email list. > > Okay, I wish this chain-reply would make people easy to find the > previous comments, but actually it is little mess now. I would give > up this way to send patchset :) > >> In the same time the patchset is quite big. Put the latest version (with >> this issue above fixed!) on some repo and link it in cover letter. > > Yeah, it's quite big now, I would like to back the patchset to previous > format, like: > > ---> [PATCH v6 00/17] Cover letter > |----> [PATCH v6 01/17] > |----> [PATCH ......] > |----> [PATCH v6 05/17] > |----> [PATCH v7 05/17] > |----> [PATCH ......] > |----> [PATCH v6 17/17] > > Is it right, and can resend the v6 to fix this chain-reply issue with > RESEND flag ([PATCH RESEND v6 ...]) ? > > ---> [PATCH RESEND v6 00/17] Cover letter > |----> [PATCH RESEND v6 01/17] > |----> [PATCH ......] > |----> [PATCH RESEND v6 05/17] > |----> [PATCH v7 05/17] > |----> [PATCH ......] > |----> [PATCH RESEND v6 17/17] > No, don't resend everything. I mean in this case with such big patchset if you want to fix one patch just send one email [PATCH v7 05/17] chained to proper id (cover letter or v6-05/17). Add a short note that this is resend of only one patch from the set. Of course you can just wait for some more comments and then send v7 of everything. Best regards, Krzysztof