From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbbJLEaA (ORCPT ); Mon, 12 Oct 2015 00:30:00 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:48429 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbbJLE36 (ORCPT ); Mon, 12 Oct 2015 00:29:58 -0400 X-AuditID: cbfec7f5-f794b6d000001495-3a-561b3743b8ef Subject: Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card To: Anand Moon , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski , Jaehoon Chung References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <561B3739.4040701@samsung.com> Date: Mon, 12 Oct 2015 13:29:45 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLLMWRmVeSWpSXmKPExsVy+t/xq7rO5tJhBnNuWlnMP3KO1eLN2zVM Fjd+tbFavH5haNH/+DWzxZuHmxktNj2+xmpxedccNosZ5/cxWazbeIvdgctj56y77B6bVnWy eWxeUu+xpR/I69uyitHj8ya5ALYoLpuU1JzMstQifbsErowVl88xFbRwV9w8/JK5gXENZxcj J4eEgInEoodH2CFsMYkL99azdTFycQgJLGWUWPb1DQuE84VR4tm7d2wgVcIC8RJzGu6xgyRE BC4AJb7uB6riAKpykWhbIgASZxZoZ5S483Y2WAObgLHE5uVLwGxeAS2J9S2/WUBsFgFViZ9v GsBsUYEIiYkTGlghagQlfky+BxbnFHCV+Pz+OTvIfGYBPYn7F7VAwswC8hKb17xlnsAoMAtJ xyyEqllIqhYwMq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECImErzsYlx6zOsQowMGoxMPL sUUqTIg1say4MvcQowQHs5IIb1QVUIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE0hNL UrNTUwtSi2CyTBycUg2MDmV1cdvnLBLOW5dzdtaNcsNDHIWXHst/1Px6/mmiSPWlx9MOtNXz a9/arlitHT+tZd6pYpsFL/m2FHI83Lfst//KObxn30xi0y1dU7n5g9/xfOO7E/vPf1SaNb/N 1Mx+TfXEg5H8BXnPOq8mxGYm83/bn2O8dnWQ21IZmYL/KxbkHVb257nSoMRSnJFoqMVcVJwI AOy+Yl+AAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.10.2015 00:46, Anand Moon wrote: > From: Jaehoon Chung > > To detect sd-card use the cd-gpio method. > It can decrease the interrupt for detecting sd-card. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Anand Moon > > --- > Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 1af5bdc..26decbd 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -352,8 +352,10 @@ > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; > samsung,dw-mshc-ddr-timing = <0 2>; > + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>; > + cd-inverted; > pinctrl-names = "default"; > - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; > + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>; Anand, You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0] pad correctly for Exynos5420 boards"). Why? There is no explanation in the commit message about this. Best regards, Krzysztof