From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034AbbJLEms (ORCPT ); Mon, 12 Oct 2015 00:42:48 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:55486 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbbJLEmq (ORCPT ); Mon, 12 Oct 2015 00:42:46 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-a4-561b3a4374ab Subject: Re: [PATCH 2/3] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3 To: Anand Moon , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski , Jaehoon Chung References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> <1444578364-1384-2-git-send-email-linux.amoon@gmail.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <561B3A3E.3030904@samsung.com> Date: Mon, 12 Oct 2015 13:42:38 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1444578364-1384-2-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xa7rOVtJhBqu3yVvMP3KO1eLN2zVM Fjd+tbFavH5haNH/+DWzxZuHmxktNj2+xmpxedccNosZ5/cxWazbeIvdgctj56y77B6bVnWy eWxeUu+xpR/I69uyitHj8ya5ALYoLpuU1JzMstQifbsErowXfxULNotXNH6KaGA8JtTFyMkh IWAisXPHBSYIW0ziwr31bF2MXBxCAksZJX78m8wO4XxhlPi9Zy47SJWwQITE74ZWsCoRgQuM Es++7mcBSQgJ1Eusa9jFCpJgFmhnlLjzdjYbSIJNwFhi8/IlbBA75CR6uyeBNfAKaEnMOtIL NJWDg0VAVeJQkwpIWBRowcQJDawQJYISPybfAyvnFHCV2HFrGjNIObOAnsT9i1ogYWYBeYnN a94yT2AUnIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihETHlx2Mi49Z HWIU4GBU4uHl2CIVJsSaWFZcmXuIUYKDWUmEN6oKKMSbklhZlVqUH19UmpNafIhRmoNFSZx3 7q73IUIC6YklqdmpqQWpRTBZJg5OqQZGD8vv+4w+REUxX9ReuVrwiNtW0c9RvNP+nmf4yte7 WsNv3583H2IFVBf9deK8cajeWlnY9cb6DU3ZvAcvvH9+eHFWyf3wIjGVJA5GG3/pogz28Ps+ G6YHzHX0ummxZM6+tfYuTs07YjTY9odVfp9x5khQ/8rSaEHHA8uPHGbfkWfUvH5ms7+IEktx RqKhFnNRcSIA3k8OGYoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.10.2015 00:46, Anand Moon wrote: > Added support for vmmc/vqmmc-supply for emmc/sd cards. > Fixed the min values for regulator ldo13_reg (VDDQ_MMC2). I can't see the description of a problem which is fixed. If you fix something, then please describe what is wrong. > Added ramp-delay for LDO9(VDD33_USB3_0). > Added ramp-delay for LDO13(VDDQ_MMC2). > Added ramp-delay for LDO15(ETH_P3V3). > > Signed-off-by: Anand Moon > > --- > Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch > > Note: > Changes need for support of UHS-I highspeed cards. > changes for vqmmc-supply for emmc is not supported. > > [ 1.831136] vdd_ldo9: ramp_delay not set > [ 1.843049] vdd_ldo13: ramp_delay not set > [ 1.850975] vdd_ldo15: ramp_delay not set > [ 1.862816] vdd_sd: ramp_delay not set > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 26decbd..58c06d3 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -157,6 +157,7 @@ > regulator-min-microvolt = <3000000>; > regulator-max-microvolt = <3000000>; > regulator-always-on; > + regulator-ramp-delay = <12000>; > }; > > ldo10_reg: LDO10 { > @@ -182,9 +183,10 @@ > > ldo13_reg: LDO13 { > regulator-name = "vdd_ldo13"; > - regulator-min-microvolt = <2800000>; > + regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <2800000>; > regulator-always-on; > + regulator-ramp-delay = <12000>; > }; > > ldo15_reg: LDO15 { > @@ -213,6 +215,7 @@ > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > regulator-always-on; > + regulator-ramp-delay = <12000>; Where did you get this value from? It looks wrong... My datasheet does not have 12000 uV/uS. > }; > > ldo24_reg: LDO24 { > @@ -338,6 +341,7 @@ > samsung,dw-mshc-ddr-timing = <0 2>; > samsung,dw-mshc-hs400-timing = <0 2>; > samsung,read-strobe-delay = <90>; > + vmmc-supply = <&ldo3_reg>; > pinctrl-names = "default"; > pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > bus-width = <8>; > @@ -352,6 +356,8 @@ > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; > samsung,dw-mshc-ddr-timing = <0 2>; > + vmmc-supply = <&ldo19_reg>; > + vqmmc-supply = <&ldo13_reg>; It looks wrong. LDO13 is used in one place as VQMMC and in other as VMMC. How did you figure out which regulator supplies which power domain? Best regards, Krzysztof > cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>; > cd-inverted; > pinctrl-names = "default"; >