From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbbJLEnx (ORCPT ); Mon, 12 Oct 2015 00:43:53 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:46677 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbbJLEnu (ORCPT ); Mon, 12 Oct 2015 00:43:50 -0400 X-AuditID: cbfee690-f794e6d0000014de-06-561b3a830241 Message-id: <561B3A83.6090607@samsung.com> Date: Mon, 12 Oct 2015 13:43:47 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Anand Moon , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> <561B3739.4040701@samsung.com> In-reply-to: <561B3739.4040701@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWyRsSkSLfZSjrM4NEiG4v5R86xWrx5u4bJ 4vULQ4v+x6+ZLd483MxosenxNVaLy7vmsFnMOL+PyWLdxlvsDpweO2fdZffYtKqTzWPzknqP Lf1AXt+WVYwenzfJBbBFcdmkpOZklqUW6dslcGV8ujCPvWAWb8Wb7wdZGxibuLsYOTkkBEwk JlxqZoawxSQu3FvP1sXIxSEksIJRYk/TS2aYogM3u5khErMYJZZ19zBBOA8YJVa8X84OUsUr oCXxceZFFhCbRUBV4uS+aYwgNpuAjsT2b8eZQGxRgTCJB+v2skLUC0r8mHyPBWSQiMB1Roln C5+wgzjMAu2MEnfezmYDqRIWiJeY03APbIOQQKrEovnPwaZyCmhLbHy1HmgqB1CDnsT9i1og YWYBeYnNa96CnSoh8JZd4sOBq4wQFwlIfJt8iAWkXkJAVmLTAajXJCUOrrjBMoFRbBaSm2Yh TJ2FZOoCRuZVjKKpBckFxUnpRSZ6xYm5xaV56XrJ+bmbGIExefrfswk7GO8dsD7EKMDBqMTD y7FFKkyINbGsuDL3EKMp0BETmaVEk/OBkZ9XEm9obGZkYWpiamxkbmmmJM77WupnsJBAemJJ anZqakFqUXxRaU5q8SFGJg5OqQbGpQHNB/xUtrGk6zDun1/Bols6KX6Z7XLV0l1vvhyfd/Co 9PQpZZO+7r4VwqXyb8ojzjWMcxuzDT7cefE0+sC849P2iTpuXyFqH/7C7mI3S9273L0fojR+ fgiwWyUTsSh8sZ54g72WxrXHDTv92XdIZ83wW/xlu2tZ3lIWw/8Gd7Ur5/0TcfDvU2Ipzkg0 1GIuKk4EAK4wajTEAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsVy+t9jQd1mK+kwg/ajZhbzj5xjtXjzdg2T xesXhhb9j18zW7x5uJnRYtPja6wWl3fNYbOYcX4fk8W6jbfYHTg9ds66y+6xaVUnm8fmJfUe W/qBvL4tqxg9Pm+SC2CLamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvM TbVVcvEJ0HXLzAE6SkmhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOY8enC PPaCWbwVb74fZG1gbOLuYuTkkBAwkThws5sZwhaTuHBvPVsXIxeHkMAsRoll3T1MEM4DRokV 75ezg1TxCmhJfJx5kQXEZhFQlTi5bxojiM0moCOx/dtxJhBbVCBM4sG6vawQ9YISPybfYwEZ JCJwnVHi2cIn7CAOs0A7o8Sdt7PZQKqEBeIl5jTcA9sgJJAqsWj+c7CpnALaEhtfrQeaygHU oCdx/6IWSJhZQF5i85q3zBMYge5E2DELoWoWkqoFjMyrGCVSC5ILipPScw3zUsv1ihNzi0vz 0vWS83M3MYLj/pnUDsaDu9wPMQpwMCrx8HJskQoTYk0sK67MPcQowcGsJMIbVQUU4k1JrKxK LcqPLyrNSS0+xGgKDISJzFKiyfnAlJRXEm9obGJmZGlkbmhhZGyuJM574xBDmJBAemJJanZq akFqEUwfEwenVANjhHxT3valiq+dtZ74Hkla+1qisPyM19ONV8IcdIvP3sp3FmeZm2xsE/Ke cd2RNv3Xu73vuTFPCPhwyc/I+PBd/utLvU0PLODx5pm5tmxD/i6d7c4FxpP/T31yYm0N13pp 4dsHLRTMZqk8/5e6SeKe1EulcIVLx/8eVvtWYtwk/kCwTu172ZIKJZbijERDLeai4kQAhwB0 5hEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/12/2015 01:29 PM, Krzysztof Kozlowski wrote: > On 12.10.2015 00:46, Anand Moon wrote: >> From: Jaehoon Chung >> >> To detect sd-card use the cd-gpio method. >> It can decrease the interrupt for detecting sd-card. >> >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Anand Moon >> >> --- >> Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch >> --- >> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> index 1af5bdc..26decbd 100644 >> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> @@ -352,8 +352,10 @@ >> samsung,dw-mshc-ciu-div = <3>; >> samsung,dw-mshc-sdr-timing = <0 4>; >> samsung,dw-mshc-ddr-timing = <0 2>; >> + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>; >> + cd-inverted; >> pinctrl-names = "default"; >> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; >> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>; Don't do change this. > > Anand, > > You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0] > pad correctly for Exynos5420 boards"). Why? There is no explanation in > the commit message about this. I don't remember to send the patch relevant to this. Hmm... Well, Is this patch really signed-off by me? Best Regards, Jaehoon Chung > > Best regards, > Krzysztof > >