From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751348AbbJLFoe (ORCPT ); Mon, 12 Oct 2015 01:44:34 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:49794 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbbJLFoc (ORCPT ); Mon, 12 Oct 2015 01:44:32 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-11-561b48bd1ff0 Subject: Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support To: Anand Moon , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski , Jaehoon Chung References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> <1444578364-1384-3-git-send-email-linux.amoon@gmail.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <561B48B7.1040201@samsung.com> Date: Mon, 12 Oct 2015 14:44:23 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1444578364-1384-3-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsVy+t/xa7p7PaTDDO7v1LKYf+Qcq8Wbt2uY LG78amO1eP3C0KL/8WtmizcPNzNabHp8jdXi8q45bBYzzu9jsli38Ra7A5fHzll32T02repk 89i8pN5jSz+Q17dlFaPH501yAWxRXDYpqTmZZalF+nYJXBm71k1lLPjDWzHhzFO2BsaV3F2M nBwSAiYSH5e9Z4OwxSQu3FsPZHNxCAksZZQ4Nu8FlPOFUeLXq23sXYwcHMICERInrhqBxEUE LjBKPPu6nwWkW0igXmLNiWPsIAlmgXZGiTtvZ4ONZRMwlti8fAnUCjmJ3u5JYA28AloSs6e+ YAQZyiKgKrFrgT9IWBRo/sQJDawQJYISPybfAyvnFHCVOLx2KRtIObOAnsT9i1ogYWYBeYnN a94yT2AUnIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihMTHlx2Mi49Z HWIU4GBU4uHl2CIVJsSaWFZcmXuIUYKDWUmEN6oKKMSbklhZlVqUH19UmpNafIhRmoNFSZx3 7q73IUIC6YklqdmpqQWpRTBZJg5OqQbGBdzqfwUuvKnP22ZYsvs3p/0T2X/GgiGfrgiXqRyN EZz+5m+GRAlj4qJPXnJBYc9uLG+KjX9Scppd4+SKVf1P1kVWLZ+28tRUo/kB7w+x7VSc1Prc Ydlpu58dX0of35jyMV7c/4OPgc2aoKspm5Jmf//4cVFJjemc73denky0bgyIVNM5az7lqhJL cUaioRZzUXEiACVk59eLAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.10.2015 00:46, Anand Moon wrote: > Added support for UHS-I bus speed 50MB/s (SDR50, DDR50) 104MB/s (SDR104) This description is not entirely correct. The MMC driver already supports these UHS speeds (you did not any code) so you rather enabled it (description of bindings says "is supported"). You mentioned DDR50 but I don't see respective property below. How do you know that these modes are really supported? I don't know. Can you convince me? > > Signed-off-by: Anand Moon > > --- > Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch > > Changes Fixed the UHS-I bus speed detedtion on cold boot. I don't get what is exactly fixed here. What was the error? What is the outcome of this fix? The log below is before or after? Best regards, Krzysztof > > [ 2.439806] mmc_host mmc1: Bus speed (slot 0) = 100000000Hz (slot req 100000000Hz, actual 100000000HZ div = 0) > [ 2.449729] mmc1: new ultra high speed SDR50 SDHC card at address aaaa > [ 2.455984] mmcblk0: mmc1:aaaa SL32G 29.7 GiB > [ 2.461743] mmcblk0: p1 p2 > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 58c06d3..ba4a87b 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -364,6 +364,10 @@ > pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>; > bus-width = <4>; > cap-sd-highspeed; > + sd-uhs-sdr12; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > }; > > &pinctrl_0 { >