From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbbJLJUF (ORCPT ); Mon, 12 Oct 2015 05:20:05 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:60824 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbbJLJUB (ORCPT ); Mon, 12 Oct 2015 05:20:01 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-19-561b7b3e7fc0 Message-id: <561B7AFF.1080707@samsung.com> Date: Mon, 12 Oct 2015 11:18:55 +0200 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgene@kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, stable@vger.kernel.org Subject: Re: [PATCH] arm: dts: Fix audio card detection on peach boards References: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> <561B578E.1050308@samsung.com> In-reply-to: <561B578E.1050308@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xa7p21dJhBiv+aVk8mLeNzWL+kXOs FmeXHWSzeP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TBYLNj5idOD0mN1wkcVj06pONo/NS+o9 +rasYvT4vEkugDWKyyYlNSezLLVI3y6BK+PRvKMsBQ1cFWc+XmNtYFzM0cXIySEhYCLR+HAd C4QtJnHh3no2EFtIYCmjxN1msS5GLiD7OaPE8e8fGEESvAJaEm9aF4I1sAioSnxY1AvWwCZg KNF7tA+sRlQgQmL56pNQ9YISPybfA6sXAao5uHs7E8hQZoHPjBJ/preAJYQF3CVO35zFDrE5 Q+Lh3evMIDangLbE+u0gF3EANehJ3L+oBRJmFpCX2LzmLfMERoFZSFbMQqiahaRqASPzKkbR 1NLkguKk9FxDveLE3OLSvHS95PzcTYyQkP+yg3HxMatDjAIcjEo8vBxbpMKEWBPLiitzDzFK cDArifDuDZIOE+JNSaysSi3Kjy8qzUktPsQozcGiJM47d9f7ECGB9MSS1OzU1ILUIpgsEwen VANjp3LTnWu13N8kP0V1X657LXbZ6UCtibHcqU8+3YHlvw0eBLc/6zr54dlh1g79rFtq1a01 LhP/b7cz2TNLqEqByXZ/8J23hgX/hdkDLkbsu75q/uM1WltCD5Ve+WC1S/frioRlj1bG8x7L P3bMItON7cM/1lnPbLpMpz67ov1Uw2qGkuPetZP4lViKMxINtZiLihMBiTeyRHUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/15 08:47, Krzysztof Kozlowski wrote: >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > index 8f4d76c..525a93a 100644 >> > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > @@ -1056,5 +1056,10 @@ >> > timeout-sec = <32>; >> > }; >> > >> > +&pmu_system_controller { > > Please put the node in alphabetical order. > >> > + assigned-clocks = <&pmu_system_controller 0>; >> > + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > I might be missing something here but isn't the first clock of > pmu_system_controller already a CLK_FIN_PLL? So you are reparenting the > FIN_PLL to FIN_PLL? No, it's not, the first PMU consumer clock is indeed CLK_FIN_PLL, but pmu_system_controller is also a clock provider. The first output clock of pmu_system_controller is CLKOUT, it's a composite mux and gate clock (registered in drivers/clk/samsung /clk-exynos-clkout.c). So the above dts change is selecting an external oscillator input of the CLKOUT mux, i.e. it will route 24 MHz clock signal from the external oscillator to the CLKOUT output pin, to which audio CODEC is connected on peach-pit AFAICS. -- Regards, Sylwester