From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752470AbbJLVCW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 12 Oct 2015 17:02:22 -0400
Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751284AbbJLVCU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 12 Oct 2015 17:02:20 -0400
Subject: Re: [PATCH v2 00/36] x86: Rewrite all syscall entries except native
 64-bit
To: Andy Lutomirski <luto@amacapital.net>
References: <cover.1444091584.git.luto@kernel.org>
 <20151009130654.GA10456@gmail.com>
 <CAFLxGvyb2JUQWToh9oQpPEAaF1hPwo4Guujsf9kqasdzYvqcTA@mail.gmail.com>
 <CALCETrU9Lb5z1Ytx-=LsUOm5eJJ4rUxVMKwkv+Kd9nSNn7SgAQ@mail.gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Brian Gerst <brgerst@gmail.com>, Denys Vlasenko <dvlasenk@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>
From: Richard Weinberger <richard@nod.at>
Message-ID: <561C1FD8.5090506@nod.at>
Date: Mon, 12 Oct 2015 23:02:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <CALCETrU9Lb5z1Ytx-=LsUOm5eJJ4rUxVMKwkv+Kd9nSNn7SgAQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 12.10.2015 um 20:41 schrieb Andy Lutomirski:
> On Mon, Oct 12, 2015 at 11:30 AM, Richard Weinberger
> <richard.weinberger@gmail.com> wrote:
>> On Fri, Oct 9, 2015 at 3:06 PM, Ingo Molnar <mingo@kernel.org> wrote:
>>> Ok, so I applied all of them to tip:x86/asm, in two phases, with small (stylistic)
>>> edits - it all seems to work fine for me so far, so I pushed it all out to -tip
>>> and linux-next.
>>>
>>
>> FYI, this breaks the UML build:
>>
>>   CC      arch/x86/um/sys_call_table_64.o
>> arch/x86/um/sys_call_table_64.c:49:1: error: unknown type name ‘sys_call_ptr_t’
>>  const sys_call_ptr_t sys_call_table[] ____cacheline_aligned = {
>>  ^
>> arch/x86/um/sys_call_table_64.c:54:2: warning: initialization makes
>> integer from pointer without a cast [enabled by default]
>>   [0 ... __NR_syscall_max] = &sys_ni_syscall,
>>   ^
>> arch/x86/um/sys_call_table_64.c:54:2: warning: (near initialization
>> for ‘sys_call_table[0]’) [enabled by default]
>> arch/x86/um/sys_call_table_64.c:54:2: error: initializer element is
>> not computable at load time
>> arch/x86/um/sys_call_table_64.c:54:2: error: (near initialization for
>> ‘sys_call_table[0]’)
>>
>> Andy, I suspect UML's syscall.h needs the sys_call_ptr_t type too?
>>
> 
> Whoops, yes.  UML has some weird casts in the syscall code that might
> be removable with that change, too.  Want to fix it or should I?

Please send a fix. I'll happily review/test it.

Thanks,
//richard