From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbbJMAKr (ORCPT ); Mon, 12 Oct 2015 20:10:47 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:35728 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbbJMAKp (ORCPT ); Mon, 12 Oct 2015 20:10:45 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-80-561c4c02ee84 Subject: Re: [PATCH 2/3] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3 To: Anand Moon References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> <1444578364-1384-2-git-send-email-linux.amoon@gmail.com> <561B3A3E.3030904@samsung.com> <561B49D0.2040305@samsung.com> <561BA3F2.5010403@samsung.com> Cc: =?UTF-8?Q?Krzysztof_Koz=c5=82owski?= , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski , Jaehoon Chung , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Linux Kernel From: Krzysztof Kozlowski Message-id: <561C4BF9.7070705@samsung.com> Date: Tue, 13 Oct 2015 09:10:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xq7pMPjJhBo9+8VrMP3KO1eLN2zVM Fjd+tbFaPP/3g93i9QtDi/7Hr5kt3jzczGix6fE1VovLu+awWcw4v4/JYt3GW+wO3B47Z91l 99i0qpPNY/OSeo8t/UBe35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZfQtvs5YsF27YmLnOqYG xikKXYycHBICJhINV+6xQ9hiEhfurWfrYuTiEBJYyihx7vJldgjnC6PE9L2/WEGqhAUiJH43 tLKB2CICahJXnq5ghSh6xySxdtI1MIdZYA2zxLpLH1hAqtgEjCU2L18C1sEroCWx6vFJZhCb RUBV4vm6LrDdokBTJ05oYIWoEZT4MfkeWC+nQLDE5I0bgeo5gIaqS0yZkgsSZhaQl9i85i3z BEaBWUg6ZiFUzUJStYCReRWjaGppckFxUnquoV5xYm5xaV66XnJ+7iZGSFR82cG4+JjVIUYB DkYlHl6OLVJhQqyJZcWVuYcYJTiYlUR45exkwoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzzt31 PkRIID2xJDU7NbUgtQgmy8TBKdXAKLRr1v1/Hv4uO9LvXug3Tz8bsf1C07QFH6wnLPROzrny kUGF3fb146VqkXoVn49+/n3u7PKTbhWmO0pOPfrlqPzf7MvGhk+/f9o57I5+7nx0pabF/cSZ N1T1mpq8OeI2d3+Z/oe52+8T9wqu+LbEex+nf1gq4Lhjicm0Jt1fupv3fuA8YJPuaa3EUpyR aKjFXFScCABi9lKqhgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.10.2015 23:33, Anand Moon wrote: > Hi Krzysztof, > > On 12 October 2015 at 17:43, Krzysztof Kozlowski > wrote: >> W dniu 12.10.2015 o 20:08, Anand Moon pisze: >>> Hi Krzysztof, >>> >>> On 12 October 2015 at 11:19, Krzysztof Kozlowski >>> wrote: >>>> On 12.10.2015 13:42, Krzysztof Kozlowski wrote: >>>>> On 12.10.2015 00:46, Anand Moon wrote: >>>>>> Added support for vmmc/vqmmc-supply for emmc/sd cards. >>>>>> Fixed the min values for regulator ldo13_reg (VDDQ_MMC2). >>>>> >>>>> I can't see the description of a problem which is fixed. If you fix >>>>> something, then please describe what is wrong. >>>>> >>>>>> Added ramp-delay for LDO9(VDD33_USB3_0). >>>>>> Added ramp-delay for LDO13(VDDQ_MMC2). >>>>>> Added ramp-delay for LDO15(ETH_P3V3). >>>>>> >>>>>> Signed-off-by: Anand Moon >>>>>> >>>>>> --- >>>>>> Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch >>>>>> >>>>>> Note: >>>>>> Changes need for support of UHS-I highspeed cards. >>>>>> changes for vqmmc-supply for emmc is not supported. >>>>>> >>>>>> [ 1.831136] vdd_ldo9: ramp_delay not set >>>>>> [ 1.843049] vdd_ldo13: ramp_delay not set >>>>>> [ 1.850975] vdd_ldo15: ramp_delay not set >>>>>> [ 1.862816] vdd_sd: ramp_delay not set >>>>>> --- >>>>>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 8 +++++++- >>>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >>>>>> index 26decbd..58c06d3 100644 >>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >>>>>> @@ -157,6 +157,7 @@ >>>>>> regulator-min-microvolt = <3000000>; >>>>>> regulator-max-microvolt = <3000000>; >>>>>> regulator-always-on; >>>>>> + regulator-ramp-delay = <12000>; >>>>>> }; >>>>>> >>>>>> ldo10_reg: LDO10 { >>>>>> @@ -182,9 +183,10 @@ >>>>>> >>>>>> ldo13_reg: LDO13 { >>>>>> regulator-name = "vdd_ldo13"; >>>>>> - regulator-min-microvolt = <2800000>; >>>>>> + regulator-min-microvolt = <1800000>; >>>>>> regulator-max-microvolt = <2800000>; >>>>>> regulator-always-on; >>>>>> + regulator-ramp-delay = <12000>; >>>>>> }; >>>>>> >>>>>> ldo15_reg: LDO15 { >>>>>> @@ -213,6 +215,7 @@ >>>>>> regulator-min-microvolt = <2800000>; >>>>>> regulator-max-microvolt = <2800000>; >>>>>> regulator-always-on; >>>>>> + regulator-ramp-delay = <12000>; >>>>> >>>>> Where did you get this value from? It looks wrong... My datasheet does >>>>> not have 12000 uV/uS. >>>> >>> >>>> Anand, >>>> >>>> We have actually been here: >>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/351601.html >>>> >>>> That time you used 8000. I asked the same question - how did you figure >>>> out the exact value. >>>> >>>> Now we have the same question - why 12000? >>>> >>>> It is completely fine to make a mistake (I do a lot of them) but please >>>> try not to make the same mistake again. >>>> >>>> BR, >>>> Krzysztof >>> >>> I will focus more in the future to clamp down my mistakes to minimal. >>> >>>> >>>>> >>>>>> }; >>>>>> >>>>>> ldo24_reg: LDO24 { >>>>>> @@ -338,6 +341,7 @@ >>>>>> samsung,dw-mshc-ddr-timing = <0 2>; >>>>>> samsung,dw-mshc-hs400-timing = <0 2>; >>>>>> samsung,read-strobe-delay = <90>; >>>>>> + vmmc-supply = <&ldo3_reg>; >>>>>> pinctrl-names = "default"; >>>>>> pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; >>>>>> bus-width = <8>; >>>>>> @@ -352,6 +356,8 @@ >>>>>> samsung,dw-mshc-ciu-div = <3>; >>>>>> samsung,dw-mshc-sdr-timing = <0 4>; >>>>>> samsung,dw-mshc-ddr-timing = <0 2>; >>>>>> + vmmc-supply = <&ldo19_reg>; >>>>>> + vqmmc-supply = <&ldo13_reg>; >>>>> >>>>> It looks wrong. LDO13 is used in one place as VQMMC and in other as >>>>> VMMC. How did you figure out which regulator supplies which power domain? >>>>> >>> >>> I refer Schematics diagram to XU4_MAIN_REV0.1.pdf >>> >>> From the PWR_PMCI_S2MPS11_LDO_CTRL document it LDO13 point to VDDQ_MMC2. >>> >> >> Aaa right, by mistake I thought that you put LDO13 here and in the node >> before, but there is LDO3, not 13. You did this correctly. >> >> But I have two other questions: >> 1. Maybe these regulators now should not be always-enabled? > > regulator-always-on can be removed: I have tested this. > >> 2. Why changing minimum voltage of LDO13 to 1.8V? The schematics says 2.8V. >> > > In the schematics diagram to XU4_MAIN_REV0.1.pdf > >>>From the EXYNOS5422 MMC UFS diagram CH2 range is VDDQ_MMC2 (1.8V/2.8V). Okay, so try to setting it to 1.8V (min and max) and see if it works correctly. On the same diagram few lines below: VDDQ_MMC2: 2.8V 250mA Best regards, Krzysztof