From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752947AbbJMAOs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 12 Oct 2015 20:14:48 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:29368 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752755AbbJMAOp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 12 Oct 2015 20:14:45 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-7e-561c4cf2b017
Subject: Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed
 support
To: Anand Moon <linux.amoon@gmail.com>
References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com>
 <1444578364-1384-3-git-send-email-linux.amoon@gmail.com>
 <561B48B7.1040201@samsung.com>
 <CANAwSgSLFviT4ZNXTYwxYs2pbrr9ozJmPMauhgRPO0556Rsr_g@mail.gmail.com>
Cc: Kukjin Kim <kgene@kernel.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Lukasz Majewski <l.majewski@samsung.com>,
        Jaehoon Chung <jh80.chung@samsung.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        "linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <561C4CEE.3050905@samsung.com>
Date: Tue, 13 Oct 2015 09:14:38 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <CANAwSgSLFviT4ZNXTYwxYs2pbrr9ozJmPMauhgRPO0556Rsr_g@mail.gmail.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xa7qffGTCDHbc5LCYf+Qcq8Wbt2uY
	LG78amO1eP3C0KL/8WtmizcPNzNabHp8jdXi8q45bBYzzu9jsli38Ra7A5fHzll32T02repk
	89i8pN5jSz+Q17dlFaPH501yAWxRXDYpqTmZZalF+nYJXBkPr+xmLjjJXtG3dxZTA2M7Wxcj
	J4eEgInEvKv7WCFsMYkL99YDxbk4hASWMkrM/XuYCcL5wijRenwjSxcjB4ewQITEiatGIA0i
	AmoSV56uYIWoeQ5Us2ALO0iCWeAVk8SDN24gNpuAscTm5UvAtvEKaEn8+36ZGcRmEVCVWLRg
	F5gtCjRz4oQGVogaQYkfk++xgNicAsES81+dYQfZyyygLjFlSi7EeHmJzWveMk9gFJiFpGMW
	QtUsJFULGJlXMYqmliYXFCel5xrqFSfmFpfmpesl5+duYoTEwZcdjIuPWR1iFOBgVOLh5dgi
	FSbEmlhWXJl7iFGCg1lJhFfOTiZMiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/cXe9DhATSE0tS
	s1NTC1KLYLJMHJxSDYwbT6hf+TXxjWpznj3DzY+PJTbb3lk0teXcA+nwU7sEujOe/07h0EvW
	EZgewDk7/LtS9MVa2aBL/3e/PqVvu9xa4a7szRfyyReYt4l3Kh/S3qnru+fTJufWnFM79hhs
	/qAU//jd0TfsJ6xXNf1oq9ov/3y9WMq8JzOvXMoJ/MU34bhJ7vE1VoeNlViKMxINtZiLihMB
	d4hNJH8CAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13.10.2015 00:32, Anand Moon wrote:
> Hi Krzysztof,
> 
> On 12 October 2015 at 11:14, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 12.10.2015 00:46, Anand Moon wrote:
>>> Added support for UHS-I bus speed 50MB/s (SDR50, DDR50) 104MB/s (SDR104)
>>
>> This description is not entirely correct. The MMC driver already
>> supports these UHS speeds (you did not any code) so you rather enabled
>> it (description of bindings says "is supported").
>>
>> You mentioned DDR50 but I don't see respective property below.
>>
>> How do you know that these modes are really supported? I don't know. Can
>> you convince me?
> 
> Setting this DDR50 capability give me this error. That's the reason to
> drop this capability.

But you mentioned it in commit message! "Added support for UHS-I ...
(DDR50)"

In the same time dropping DDR50 is not an sufficient proof that "SDR50
and SDR104 are really supported".

Best regards,
Krzysztof