From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932269AbbJMBmA (ORCPT ); Mon, 12 Oct 2015 21:42:00 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:32925 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932110AbbJMBl7 (ORCPT ); Mon, 12 Oct 2015 21:41:59 -0400 Subject: Re: [PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized To: Jan Kara References: <1444652698-28292-1-git-send-email-liaotonglang@gmail.com> <20151012125835.GD17050@quack.suse.cz> Cc: tj@kernel.org, axboe@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Liao Tonglang Message-ID: <561C6160.2090400@gmail.com> Date: Tue, 13 Oct 2015 09:41:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151012125835.GD17050@quack.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/12 20:58, Jan Kara wrote: > What > gcc version are you using? It is the last line of my gcc -v command. gcc version 4.8.3 20140911 (Red Hat 4.8.3-9) (GCC) And it warn like this: mm/page-writeback.c: In function ‘balance_dirty_pages.isra.26’: mm/page-writeback.c:1537:26: warning: ‘m_thresh’ may be used uninitialized in this function [-Wmaybe-uninitialized] unsigned long m_dirty, m_thresh, m_bg_thresh; ^ mm/page-writeback.c:1537:17: warning: ‘m_dirty’ may be used uninitialized in this function [-Wmaybe-uninitialized] unsigned long m_dirty, m_thresh, m_bg_thresh; ^