From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbbJMCGR (ORCPT ); Mon, 12 Oct 2015 22:06:17 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:39833 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182AbbJMCGO (ORCPT ); Mon, 12 Oct 2015 22:06:14 -0400 X-AuditID: cbfee691-f79d66d000001509-98-561c671492e3 Message-id: <561C6713.1070508@samsung.com> Date: Tue, 13 Oct 2015 11:06:11 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Anand Moon , Anand Moon , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski Cc: "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> <561B3739.4040701@samsung.com> <561B3A83.6090607@samsung.com> <1111856990.2419183.1444661252893.JavaMail.yahoo@mail.yahoo.com> <561C4C88.2040004@samsung.com> In-reply-to: <561C4C88.2040004@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkQFckXSbM4N1UMYv5R86xWrx5u4bJ 4vULQ4v+x6+ZLd483MxosenxNVaLy7vmsFnMOL+PyWLdxlvsFtfvT2N24PLYOesuu8emVZ1s HpuX1Hts6Qfy+rasYvT4vEnOY9asw0wB7FFcNimpOZllqUX6dglcGd9PH2IpeCRQsW3netYG xh7eLkZODgkBE4nrV1+yQdhiEhfurQeyuTiEBFYwSnxp7GOEKdq0/TAjRGIWo0Tb18csEM4D RonOw/1g7bwCWhJXeiawg9gsAqoS3x41gnWzCehIbP92nAnEFhUIk3iwbi8rRL2gxI/J98AG iQj8YZT4en4W2CBmgVlMEtMuJIDYwgLxEnMa7rFDbHvBKLG7bz9YN6eAtsTF9qVA3RxADeoS U6bkQvTKS2xe85YZpF5C4Cu7xMvbt1ghLhKQ+Db5EFi9hICsxKYDzBCvSUocXHGDZQKj2Cwk N81CmDoLydQFjMyrGEVTC5ILipPSi0z1ihNzi0vz0vWS83M3MQLj9PS/ZxN3MN4/YH2IUYCD UYmH90WkTJgQa2JZcWXuIUZToCMmMkuJJucDk0FeSbyhsZmRhamJqbGRuaWZkjivjvTPYCGB 9MSS1OzU1ILUovii0pzU4kOMTBycUg2MXjcyQwvkOJ/2BMXFMeyOiRDetcCqc6/y5/h9zy1T 1CvF/5lsl11061zz+v/RzxxU7krdllVbfUSO4apY+rybF6d1rnz9NP5Moa1+58+Y3af7r6S/ jUk/lmH/JrOWc0ObuaON72sLn2NJa1QWxfy43eEjPV+J43IW5y7+T83l6+p2dTZrzVVSYinO SDTUYi4qTgQAozli1c4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42I5/e+xoK5IukyYwfMZAhbzj5xjtXjzdg2T xesXhhb9j18zW7x5uJnRYtPja6wWl3fNYbOYcX4fk8W6jbfYLa7fn8bswOWxc9Zddo9NqzrZ PDYvqffY0g/k9W1ZxejxeZOcx6xZh5kC2KMaGG0yUhNTUosUUvOS81My89JtlbyD453jTc0M DHUNLS3MlRTyEnNTbZVcfAJ03TJzgM5TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesbEgTX Y2SABhLWMGZ8P32IpeCRQMW2netZGxh7eLsYOTkkBEwkNm0/zAhhi0lcuLeerYuRi0NIYBaj RNvXxywQzgNGic7D/WwgVbwCWhJXeiawg9gsAqoS3x41gnWzCehIbP92nAnEFhUIk3iwbi8r RL2gxI/J98AGiQj8YZT4en4W2CBmgVlMEtMuJIDYwgLxEnMa7rFDbHvBKLG7bz9YN6eAtsTF 9qVA3RxADeoSU6bkQvTKS2xe85Z5AiPQnQg7ZiFUzUJStYCReRWjRGpBckFxUnquYV5quV5x Ym5xaV66XnJ+7iZGcCp4JrWD8eAu90OMAhyMSjy8LyJlwoRYE8uKK3MPMUpwMCuJ8OYEA4V4 UxIrq1KL8uOLSnNSiw8xmgIDYSKzlGhyPjBN5ZXEGxqbmBlZGpkbWhgZmyuJ8944xBAmJJCe WJKanZpakFoE08fEwSnVwLg+bUm61A5fDcMKD9EFWZ/WVbrpfi2YsOVtu9T825+2Ltz6/t1C +bp2VakrWWFmDzhXOi6QuTHRNvty9ZbjZ1z+pc1/9W+Vzv2DP+30I6Y8mRHc//bH6RMv5nTK VPya+OnAQd0Ja5+eFFLY/W6fpzOf1OmQLB0Rn5iVB5Z68xZHfHc14Y5i/XJNiaU4I9FQi7mo OBEASFDV3xsDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear, Anand. On 10/13/2015 09:12 AM, Krzysztof Kozlowski wrote: > On 12.10.2015 23:47, Anand Moon wrote: >>> >>> Anand, >>> >>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0] >>> pad correctly for Exynos5420 boards"). Why? There is no explanation in >>> the commit message about this. >> >> I don't remember to send the patch relevant to this. Hmm... >> Well, Is this patch really signed-off by me? >> >> Best Regards, >> >> Jaehoon Chung >>> >>> Best regards, >>> Krzysztof >>> >> >>> >> >> >> Some how I don't receive these mail on my email id. >> >> I have picked up these changes from tizen repository for OdroidXU3. >> I have tested with this changes to detect UHS-I micro cd cards. >> That's the reason for this email. It seems to make manually, right? I have checked the tizen repository. The below is --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts @@ -335,7 +335,9 @@ samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; pinctrl-names = "default"; - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; + cd-gpios = <&gpc2 2 0>; + cd-inverted; + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus1 &sd2_bus4>; bus-width = <4>; cap-sd-highspeed; }; Yours --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -352,8 +352,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>; + cd-inverted; pinctrl-names = "default"; - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>; Did you know what differ? :) Best Regards, Jaehoon Chung > > ... and you applied it blindly without looking at actual existing > contents and at previous commits. > > That is not how patches from different repositories should be cherry picked. > > Best regards, > Krzysztof > >