From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932240AbbJMCjU (ORCPT ); Mon, 12 Oct 2015 22:39:20 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:56883 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932092AbbJMCjR (ORCPT ); Mon, 12 Oct 2015 22:39:17 -0400 X-AuditID: cbfee691-f79d66d000001509-e6-561c6ed38de9 Message-id: <561C6ED3.4090101@samsung.com> Date: Tue, 13 Oct 2015 11:39:15 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Anand Moon , Krzysztof Kozlowski Cc: =?UTF-8?B?S3J6eXN6dG9mIEtvesWCb3dza2k=?= , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Linux Kernel Subject: Re: [PATCH 2/3] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3 References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> <1444578364-1384-2-git-send-email-linux.amoon@gmail.com> <561B3A3E.3030904@samsung.com> <561B49D0.2040305@samsung.com> <561BA3F2.5010403@samsung.com> <561C4BF9.7070705@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsWyRsSkWPdynkyYwfTnChbzj5xjtXjzdg2T xfN/P9gtXr8wtOh//JrZ4s3DzYwWmx5fY7W4vGsOm8WM8/uYLNZtvMXuwOWxc9Zddo9NqzrZ PDYvqffY0g/k9W1ZxejxeZNcAFsUl01Kak5mWWqRvl0CV8bjQw/ZCl5ZVaxo62dqYGzR7WLk 4JAQMJHYdjuyi5ETyBSTuHBvPVsXIxeHkMAKRolXz/pYIRImEveaJzJBJJYySryf+pUFwnnA KPH12yRmkCpeAS2JU203wGwWAVWJ3iWHwLrZBHQktn87zgRiiwqESTxYt5cVol5Q4sfkeywg tohAuMSU7/fBhjILtDFLLD39hh0kISwQIfG7oRXqpmvMEgfezQPbwCkQLPGsYQobyA/MAuoS U6bkgoSZBeQlNq95ywxSLyHwll3i/52LTBAXCUh8m3yIBeJnWYlNB5ghXpOUOLjiBssERrFZ SG6ahTB1FpKpCxiZVzGKphYkFxQnpReZ6hUn5haX5qXrJefnbmIExubpf88m7mC8f8D6EKMA B6MSD++LSJkwIdbEsuLK3EOMpkBHTGSWEk3OByaAvJJ4Q2MzIwtTE1NjI3NLMyVxXh3pn8FC AumJJanZqakFqUXxRaU5qcWHGJk4OKUaGOv950h/yy152Pr6rf7+dwcn+H3UDNlkuOOlZ6Ua z+OVB2XbfSInxc5n9HFffSZ//9/J75S036u94V99/7XCqd4DUz/9mveqxtGwWMp+QabQdx/W 2T7NTAZfav6/LSyY8KAj5d7Ee56rO+4/Lvge+MDl5eSVN+a6yvnea/L4acoSw3SET5UlKluJ pTgj0VCLuag4EQDCL4e5yAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42I5/e+xgO7lPJkwg/5tUhbzj5xjtXjzdg2T xfN/P9gtXr8wtOh//JrZ4s3DzYwWmx5fY7W4vGsOm8WM8/uYLNZtvMXuwOWxc9Zddo9NqzrZ PDYvqffY0g/k9W1ZxejxeZNcAFtUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWF uZJCXmJuqq2Si0+ArltmDtBlSgpliTmlQKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDC GsaMx4ceshW8sqpY0dbP1MDYotvFyMkhIWAica95IhOELSZx4d56ti5GLg4hgaWMEu+nfmWB cB4wSnz9NokZpIpXQEviVNsNMJtFQFWid8khVhCbTUBHYvu342CTRAXCJB6s28sKUS8o8WPy PRYQW0QgXGLK9/tgQ5kF2pgllp5+ww6SEBaIkPjd0Aq1+hqzxIF388A2cAoESzxrmAKU4ADq UJeYMiUXJMwsIC+xec1b5gmMArOQ7JiFUDULSdUCRuZVjBKpBckFxUnpuUZ5qeV6xYm5xaV5 6XrJ+bmbGMEJ4Jn0DsbDu9wPMQpwMCrx8L6IlAkTYk0sK67MPcQowcGsJMJ7LgsoxJuSWFmV WpQfX1Sak1p8iNEUGAgTmaVEk/OBySmvJN7Q2MTMyNLI3NDCyNhcSZz3xiGGMCGB9MSS1OzU 1ILUIpg+Jg5OqQbGVA3lDkeVww/dw98/rH2RpjX7k71jaPPtz3FXrpo8XiBmcs+8oeWA5MO1 3QE7bJyLmA8IfKrOL7PjXLe2wm+abUEfq/qymx5Gk9pvcVm8uMSwfH9MZdo6pi/fheemz90c Eh3i9fzisr4dj4z0xJ4ryevOn/h8qfeRxn2JiiU1wa94dCcU/9mkxFKckWioxVxUnAgAcKjM fxYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 11:29 AM, Anand Moon wrote: > Hi Krzysztof, > > On 13 October 2015 at 05:40, Krzysztof Kozlowski > wrote: >> On 12.10.2015 23:33, Anand Moon wrote: >>> Hi Krzysztof, >>> >>> On 12 October 2015 at 17:43, Krzysztof Kozlowski >>> wrote: >>>> W dniu 12.10.2015 o 20:08, Anand Moon pisze: >>>>> Hi Krzysztof, >>>>> >>>>> On 12 October 2015 at 11:19, Krzysztof Kozlowski >>>>> wrote: >>>>>> On 12.10.2015 13:42, Krzysztof Kozlowski wrote: >>>>>>> On 12.10.2015 00:46, Anand Moon wrote: >>>>>>>> Added support for vmmc/vqmmc-supply for emmc/sd cards. >>>>>>>> Fixed the min values for regulator ldo13_reg (VDDQ_MMC2). >>>>>>> >>>>>>> I can't see the description of a problem which is fixed. If you fix >>>>>>> something, then please describe what is wrong. >>>>>>> >>>>>>>> Added ramp-delay for LDO9(VDD33_USB3_0). >>>>>>>> Added ramp-delay for LDO13(VDDQ_MMC2). >>>>>>>> Added ramp-delay for LDO15(ETH_P3V3). >>>>>>>> >>>>>>>> Signed-off-by: Anand Moon >>>>>>>> >>>>>>>> --- >>>>>>>> Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch >>>>>>>> >>>>>>>> Note: >>>>>>>> Changes need for support of UHS-I highspeed cards. >>>>>>>> changes for vqmmc-supply for emmc is not supported. >>>>>>>> >>>>>>>> [ 1.831136] vdd_ldo9: ramp_delay not set >>>>>>>> [ 1.843049] vdd_ldo13: ramp_delay not set >>>>>>>> [ 1.850975] vdd_ldo15: ramp_delay not set >>>>>>>> [ 1.862816] vdd_sd: ramp_delay not set >>>>>>>> --- >>>>>>>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 8 +++++++- >>>>>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >>>>>>>> index 26decbd..58c06d3 100644 >>>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >>>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >>>>>>>> @@ -157,6 +157,7 @@ >>>>>>>> regulator-min-microvolt = <3000000>; >>>>>>>> regulator-max-microvolt = <3000000>; >>>>>>>> regulator-always-on; >>>>>>>> + regulator-ramp-delay = <12000>; >>>>>>>> }; >>>>>>>> >>>>>>>> ldo10_reg: LDO10 { >>>>>>>> @@ -182,9 +183,10 @@ >>>>>>>> >>>>>>>> ldo13_reg: LDO13 { >>>>>>>> regulator-name = "vdd_ldo13"; >>>>>>>> - regulator-min-microvolt = <2800000>; >>>>>>>> + regulator-min-microvolt = <1800000>; >>>>>>>> regulator-max-microvolt = <2800000>; >>>>>>>> regulator-always-on; >>>>>>>> + regulator-ramp-delay = <12000>; >>>>>>>> }; >>>>>>>> >>>>>>>> ldo15_reg: LDO15 { >>>>>>>> @@ -213,6 +215,7 @@ >>>>>>>> regulator-min-microvolt = <2800000>; >>>>>>>> regulator-max-microvolt = <2800000>; >>>>>>>> regulator-always-on; >>>>>>>> + regulator-ramp-delay = <12000>; >>>>>>> >>>>>>> Where did you get this value from? It looks wrong... My datasheet does >>>>>>> not have 12000 uV/uS. >>>>>> >>>>> >>>>>> Anand, >>>>>> >>>>>> We have actually been here: >>>>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/351601.html >>>>>> >>>>>> That time you used 8000. I asked the same question - how did you figure >>>>>> out the exact value. >>>>>> >>>>>> Now we have the same question - why 12000? >>>>>> >>>>>> It is completely fine to make a mistake (I do a lot of them) but please >>>>>> try not to make the same mistake again. >>>>>> >>>>>> BR, >>>>>> Krzysztof >>>>> >>>>> I will focus more in the future to clamp down my mistakes to minimal. >>>>> >>>>>> >>>>>>> >>>>>>>> }; >>>>>>>> >>>>>>>> ldo24_reg: LDO24 { >>>>>>>> @@ -338,6 +341,7 @@ >>>>>>>> samsung,dw-mshc-ddr-timing = <0 2>; >>>>>>>> samsung,dw-mshc-hs400-timing = <0 2>; >>>>>>>> samsung,read-strobe-delay = <90>; >>>>>>>> + vmmc-supply = <&ldo3_reg>; >>>>>>>> pinctrl-names = "default"; >>>>>>>> pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; >>>>>>>> bus-width = <8>; >>>>>>>> @@ -352,6 +356,8 @@ >>>>>>>> samsung,dw-mshc-ciu-div = <3>; >>>>>>>> samsung,dw-mshc-sdr-timing = <0 4>; >>>>>>>> samsung,dw-mshc-ddr-timing = <0 2>; >>>>>>>> + vmmc-supply = <&ldo19_reg>; >>>>>>>> + vqmmc-supply = <&ldo13_reg>; >>>>>>> >>>>>>> It looks wrong. LDO13 is used in one place as VQMMC and in other as >>>>>>> VMMC. How did you figure out which regulator supplies which power domain? >>>>>>> >>>>> >>>>> I refer Schematics diagram to XU4_MAIN_REV0.1.pdf >>>>> >>>>> From the PWR_PMCI_S2MPS11_LDO_CTRL document it LDO13 point to VDDQ_MMC2. >>>>> >>>> >>>> Aaa right, by mistake I thought that you put LDO13 here and in the node >>>> before, but there is LDO3, not 13. You did this correctly. >>>> >>>> But I have two other questions: >>>> 1. Maybe these regulators now should not be always-enabled? >>> >>> regulator-always-on can be removed: I have tested this. >>> >>>> 2. Why changing minimum voltage of LDO13 to 1.8V? The schematics says 2.8V. >>>> >>> >>> In the schematics diagram to XU4_MAIN_REV0.1.pdf >>> >>> >From the EXYNOS5422 MMC UFS diagram CH2 range is VDDQ_MMC2 (1.8V/2.8V). >> >> Okay, so try to setting it to 1.8V (min and max) and see if it works >> correctly. >> >> On the same diagram few lines below: >> VDDQ_MMC2: 2.8V 250mA >> > > You are correct. > While working on this issue I tent to encounter make bugs. > --------------------------------------------------------------------------------- > [ 4.713553] random: nonblocking pool is initialized > [ 4.718423] 14530000.hdmi supply hdmi-en not found, using dummy regulator > [ 4.726206] exynos-drm exynos-drm: bound 14400000.fimd (ops > fimd_component_ops) > [ 4.732555] exynos-drm exynos-drm: bound 14450000.mixer (ops > mixer_component_ops) > [ 4.740180] exynos-drm exynos-drm: bound 14530000.hdmi (ops > hdmi_component_ops) > [ 4.746936] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). > [ 4.753428] [drm] No driver support for vblank timestamp query. > [ 4.940794] Console: switching to colour frame buffer device 274x77 > [ 4.995344] exynos-drm exynos-drm: fb0: frame buffer device > [ 5.024573] [drm] Initialized exynos 1.0.0 20110530 on minor 0 > [ 5.031164] exynos-dwc3 usb@12000000: no suspend clk specified > [ 5.054571] usb 2-1: new full-speed USB device number 2 using exynos-ohci > [ 5.159527] dwmmc_exynos 12220000.mmc: Busy; trying anyway > [ 5.163705] mmc_host mmc1: Timeout sending command (cmd 0x202000 > arg 0x0 status 0x0) > --------------------------------------------------------------------------------- > This is one bug. related to this changes. It stops booting waiting for > the mmc1 card. It seems that it failed to switch voltage. Best Regards, Jaehoon Chung > > -Anand Moon > >> Best regards, >> Krzysztof >