* [PATCH] drivers :staging: android: make alignment match open parenthesis
@ 2015-10-13 3:32 Liao Tonglang
2015-10-13 5:40 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Liao Tonglang @ 2015-10-13 3:32 UTC (permalink / raw)
To: gregkh, arve, riandrews; +Cc: devel, linux-kernel, Liao Tonglang
Cleanup for checkpatch.pl warn below:
CHECK: Alignment should match open parenthesis
#836: FILE: drivers/staging/android/ashmem.c:836:
by split three lines to four.
Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
---
drivers/staging/android/ashmem.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 60200a3..99fc7dc 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -832,9 +832,10 @@ static int __init ashmem_init(void)
{
int ret;
- ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
- sizeof(struct ashmem_area),
- 0, 0, NULL);
+ ashmem_area_cachep =
+ kmem_cache_create("ashmem_area_cache",
+ sizeof(struct ashmem_area),
+ 0, 0, NULL);
if (unlikely(!ashmem_area_cachep)) {
pr_err("failed to create slab cache\n");
return -ENOMEM;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers :staging: android: make alignment match open parenthesis
2015-10-13 3:32 [PATCH] drivers :staging: android: make alignment match open parenthesis Liao Tonglang
@ 2015-10-13 5:40 ` Greg KH
2015-10-13 6:24 ` Liao Tonglang
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2015-10-13 5:40 UTC (permalink / raw)
To: Liao Tonglang; +Cc: arve, riandrews, devel, linux-kernel
On Tue, Oct 13, 2015 at 11:32:31AM +0800, Liao Tonglang wrote:
> Cleanup for checkpatch.pl warn below:
> CHECK: Alignment should match open parenthesis
> #836: FILE: drivers/staging/android/ashmem.c:836:
> by split three lines to four.
>
> Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 60200a3..99fc7dc 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -832,9 +832,10 @@ static int __init ashmem_init(void)
> {
> int ret;
>
> - ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
> - sizeof(struct ashmem_area),
> - 0, 0, NULL);
> + ashmem_area_cachep =
> + kmem_cache_create("ashmem_area_cache",
> + sizeof(struct ashmem_area),
> + 0, 0, NULL);
Now you are just getting very picky for checkpatch issues, is this
really more readable?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers :staging: android: make alignment match open parenthesis
2015-10-13 5:40 ` Greg KH
@ 2015-10-13 6:24 ` Liao Tonglang
0 siblings, 0 replies; 3+ messages in thread
From: Liao Tonglang @ 2015-10-13 6:24 UTC (permalink / raw)
To: Greg KH; +Cc: arve, riandrews, devel, linux-kernel
On Tue, Oct 13, 2015 at 11:40:00AM +0800, Greg KH wrote:
>> - ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
>> - sizeof(struct ashmem_area),
>> - 0, 0, NULL);
>> + ashmem_area_cachep =
>> + kmem_cache_create("ashmem_area_cache",
>> + sizeof(struct ashmem_area),
>> + 0, 0, NULL);
> is this really more readable?
You are right. The four-line version looks stupid. Just ignore
these changes.
Thanks for your patience,
liao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-13 6:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 3:32 [PATCH] drivers :staging: android: make alignment match open parenthesis Liao Tonglang
2015-10-13 5:40 ` Greg KH
2015-10-13 6:24 ` Liao Tonglang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox