From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932190AbbJMIEB (ORCPT ); Tue, 13 Oct 2015 04:04:01 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49356 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932145AbbJMIDx (ORCPT ); Tue, 13 Oct 2015 04:03:53 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f791c6d000001498-10-561cbae7a799 Content-transfer-encoding: 8BIT Message-id: <561CBAE7.1070300@samsung.com> Date: Tue, 13 Oct 2015 17:03:51 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lee Jones Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, beomho.seo@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device References: <1444655578-19806-1-git-send-email-ingi2.kim@samsung.com> <1444655578-19806-3-git-send-email-ingi2.kim@samsung.com> <20151013070610.GO17172@x1> In-reply-to: <20151013070610.GO17172@x1> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsWyRsSkUPf5Lpkwg2ezhC1Of9rGbjH/yDlW i/43C1ktzr1ayWgx6f4EFoveq88ZLe5/PcpocXnXHDaLrW/WMVosvX6RyWLC9LUsFq17j7Bb 7N71lNXidDerxYzJL9kc+D3WzFvD6HG5r5fJY+XyL2wem1Z1snncubaHzWPeyUCPPfN/sHr0 bVnF6PF5k1wAZxSXTUpqTmZZapG+XQJXxpqf09gKfnNW7Gh4xNzAeJ+9i5GTQ0LARKLj5jtW CFtM4sK99WxdjFwcQgIrGCV+HbvHClO09+hkqMRSRolpHZvAErwCghI/Jt9j6WLk4GAWkJc4 cikbwlSXmDIlF6L8AaPE355vzBDlWhKLvpxlArFZBFQlDu38wQJiswmoSdxYsRAsLiqQIHH8 7A8mkDkiAioS596Yg8xhFrjLJLHx5G2wo4UFPCRaNzyGumc+o8T9H/PAFnAKaEgceL+NBSQh IbCUQ2LZyQmMENsEJL5NPgR2qISArMSmA8wQj0lKHFxxg2UCo9gsJO/MQnhnFsI7CxiZVzGK phYkFxQnpRcZ6RUn5haX5qXrJefnbmIExvnpf8/6djDePGB9iFGAg1GJh/dFpEyYEGtiWXFl 7iFGU6AbJjJLiSbnA5NJXkm8obGZkYWpiamxkbmlmZI4b4LUz2AhgfTEktTs1NSC1KL4otKc 1OJDjEwcnFINjKEeQinulqIdlQY1ez5PvPrWwyI67S53otPpMw82e+rldSk9TDtSryYruUFw 51Q3zYPF4l6H9YVjYpmzzq5ZeD673mxn0+rCWK6kg9cDOJMYZeZpXvFK0Q172bXps4SZ05T+ JY3sL4vOzFwQ2i6yolRm+/q/B5ifdYbv2xZ+VMti2fxVf14VKLEUZyQaajEXFScCAK2j3g/u AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsVy+t9jAd3nu2TCDLqbeS1Of9rGbjH/yDlW i/43C1ktzr1ayWgx6f4EFoveq88ZLe5/PcpocXnXHDaLrW/WMVosvX6RyWLC9LUsFq17j7Bb 7N71lNXidDerxYzJL9kc+D3WzFvD6HG5r5fJY+XyL2wem1Z1snncubaHzWPeyUCPPfN/sHr0 bVnF6PF5k1wAZ1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKL T4CuW2YO0AdKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIaxow1P6exFfzm rNjR8Ii5gfE+excjJ4eEgInE3qOT2SBsMYkL99YD2VwcQgJLGSWmdWxiBUnwCghK/Jh8j6WL kYODWUBe4silbAhTXWLKlFyI8geMEn97vjFDlGtJLPpylgnEZhFQlTi08wcLiM0moCZxY8VC sLioQILE8bM/mEDmiAioSJx7Yw4yh1ngLpPExpO3wW4TFvCQaN3wGOqe+YwS93/MA1vAKaAh ceD9NpYJjAKzkJw3C+G8WQjnLWBkXsUokVqQXFCclJ5rmJdarlecmFtcmpeul5yfu4kRnEqe Se1gPLjL/RCjAAejEg/vi0iZMCHWxLLiytxDjBIczEoivEktQCHelMTKqtSi/Pii0pzU4kOM pkD/TWSWEk3OB6a5vJJ4Q2MTMyNLI3NDCyNjcyVx3huHGMKEBNITS1KzU1MLUotg+pg4OKUa GOVbze2mRZUwZET1HuRh+6jZbPz/kIu7G0f1gXmM3z7MXbJjW363sdizy18c5k408p/luLd+ 6ZOfNW/OfPlyR+eib3XrThPD5Os3m+el/TtyTWtSlWXWLS6/pNWrdzHbqCwWupDmWPPcbo7P 4sDZ9j+sJQx9o9p1Vz/l1dOrOS5kdzVAYF+gixJLcUaioRZzUXEiAM2CIow7AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee Jones, Okay, I'm try to remove needless part and resend it Thanks for the review Thank you On 2015년 10월 13일 16:06, Lee Jones wrote: > On Mon, 12 Oct 2015, Ingi Kim wrote: > >> This patch adds rt5033-led sub device to support it. >> >> Signed-off-by: Ingi Kim >> --- >> drivers/mfd/rt5033.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c >> index d60f916..b7f374b 100644 >> --- a/drivers/mfd/rt5033.c >> +++ b/drivers/mfd/rt5033.c >> @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = { >> }; >> >> static const struct mfd_cell rt5033_devs[] = { >> - { .name = "rt5033-regulator", }, >> { >> + .name = "rt5033-regulator", >> + }, { > > There's no need for this change. Please remove it. > >> .name = "rt5033-charger", >> .of_compatible = "richtek,rt5033-charger", >> }, { >> .name = "rt5033-battery", >> .of_compatible = "richtek,rt5033-battery", >> + }, { >> + .name = "rt5033-led", >> + .of_compatible = "richtek,rt5033-led", > > For when you resubmit with the hunk above removed: > > Acked-by: Lee Jones > >> }, >> }; >> >