From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752334AbbJMIqc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 13 Oct 2015 04:46:32 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:56098 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751853AbbJMIqG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 13 Oct 2015 04:46:06 -0400
Subject: Re: [PATCH] EDAC: use debugfs_remove_recursive instead of
 debugfs_remove
To: Borislav Petkov <bp@alien8.de>
References: <1444702971-94112-1-git-send-email-tanxiaojun@huawei.com>
 <20151013074121.GA17498@pd.tnic>
CC: <dougthompson@xmission.com>, <mchehab@osg.samsung.com>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Tan Xiaojun <tanxiaojun@huawei.com>
Message-ID: <561CC4A6.8060401@huawei.com>
Date: Tue, 13 Oct 2015 16:45:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20151013074121.GA17498@pd.tnic>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.21.79]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/10/13 15:41, Borislav Petkov wrote:
> On Tue, Oct 13, 2015 at 10:22:51AM +0800, Tan Xiaojun wrote:
>> debugfs_remove is used to remove a file or an empty directory from
>> the debugfs filesystem, but mci->debugfs is not empty.
> 
> How exactly do you trigger this? And by "this" I'm not even sure what
> the problem is as your commit message doesn't say. So please explain
> also what the problem is.
> 
> Also, use this branch instead:
> 
> http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
> 
> We did change EDAC debugfs handling recently so your patch doesn't apply
> anymore.
> 
> Thanks.
> 

Sorry, I don't describe it well. I do test like that:
1)open EDAC config and open CONFIG_EDAC_DEBUG
2)insmod a edac_mc module (like i3000_edac or others in drivers/edac/)
3)rmmod this module
4)we can also see files under /sys/kernel/debug/edac/ like "fake_inject"

If you think this patch is OK, I will do patch in your branch and send V2.

Thanks.
Xiaojun