From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932363AbbJMK4I (ORCPT ); Tue, 13 Oct 2015 06:56:08 -0400 Received: from smtp-out-007.synserver.de ([212.40.185.7]:1053 "EHLO smtp-out-100.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751769AbbJMK4H (ORCPT ); Tue, 13 Oct 2015 06:56:07 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 26956 Message-ID: <561CE342.9020700@metafoo.de> Date: Tue, 13 Oct 2015 12:56:02 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Jonathan Cameron , Daniel Baluta , Jonathan Cameron CC: Cristina Opriceana , "linux-iio@vger.kernel.org" , "octavian.purdila@intel.com" , Hartmut Knaack , Peter Meerwald , Linux Kernel Mailing List Subject: Re: [PATCH] iio: Move IIO Dummy Driver out of staging References: <33d5396ef3a2c8ebe9a076a611bda60f9a1ae1e0.1444396827.git.cristina.opriceana@gmail.com> <561A63EE.5040206@kernel.org> <2696972F-5414-4DD5-AA66-08254496633D@jic23.retrosnub.co.uk> In-Reply-To: <2696972F-5414-4DD5-AA66-08254496633D@jic23.retrosnub.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 07:44 AM, Jonathan Cameron wrote: > > > On 12 October 2015 18:59:57 BST, Daniel Baluta wrote: >> >> >>>> +static unsigned instances = 1; >>>> +module_param(instances, uint, 0); >> >> One concern about this. We will still create a default number of >> 'instances' >> when using configuration via configfs? >> >> I'm not sure we can remove this parameter once the module is moved >> out of staging, since we break the ABI (?) > I'm not that bothered about ABI breakage on this one. Not going to break anything > real after all! ABI gets only broken if there is somebody to complain about it ;)