Re: [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller

Arnd Bergmann
2015-10-13T12:10:16Z

On Tuesday 13 October 2015 17:06:18 Alim Akhtar wrote:
> > Better rename them to "core", "ref" and "iface", no point requiring to
> > spell out "clk" here.
> >
> >> + ufs,pwr-attr-mode = "FAST";
> >
> > A string is rather unusual here, what are the allowed values? Could you
> > use a boolean property instead?
> >
> will update the binding, supported modes are FAST, SLOW, FAST_auto etc,
> so kept the string for more readability
>
> >> + ufs,pwr-attr-lane = /bits/ 8 <2>;
> >> + ufs,pwr-attr-gear = /bits/ 8 <2>;
> >
> > Why the "/bits/ 8" ?
> >
> I am using of_property_read_u8() to read 8 bit value from property.
>

I still think it would be better to stay with conventional methods here,
and change the code accordingly. You can easily use of_property_read_u32
for the last two properties.

Arnd