Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static

Kishon Vijay Abraham I
2015-10-13T14:02:16Z

Hi,

On Tuesday 13 October 2015 05:08 PM, Alim Akhtar wrote:
> HI
> How I am support to handle this patch? Should I just fix these warnings
> in my patch or I just add this as a separate patch on the top of the
> series?

This series has not been merged yet. So you can fix this patch.

Thanks
Kishon
>
>
> On 10/01/2015 04:34 PM, kbuild test robot wrote:
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>> phy-exynos-ufs.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/phy-exynos-ufs.c b/drivers/phy/phy-exynos-ufs.c
>> index 343fcaf..835ee78 100644
>> --- a/drivers/phy/phy-exynos-ufs.c
>> +++ b/drivers/phy/phy-exynos-ufs.c
>> @@ -66,7 +66,7 @@ static bool match_cfg_to_pwr_mode(u8 desc, u8
>> required_pwr)
>> return false;
>> }
>>
>> -int exynos_ufs_phy_calibrate(struct phy *phy, enum phy_cfg_tag tag,
>> u8 pwr)
>> +static int exynos_ufs_phy_calibrate(struct phy *phy, enum phy_cfg_tag
>> tag, u8 pwr)
>> {
>> struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy);
>> struct exynos_ufs_phy_cfg **cfgs = ufs_phy->cfg;
>> @@ -93,14 +93,14 @@ out:
>> return 0;
>> }
>>
>> -void exynos_ufs_phy_set_lane_cnt(struct phy *phy, u8 lane_cnt)
>> +static void exynos_ufs_phy_set_lane_cnt(struct phy *phy, u8 lane_cnt)
>> {
>> struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy);
>>
>> ufs_phy->lane_cnt = lane_cnt;
>> }
>>
>> -int exynos_ufs_phy_wait_for_lock_acq(struct phy *phy)
>> +static int exynos_ufs_phy_wait_for_lock_acq(struct phy *phy)
>> {
>> struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy);
>> const unsigned int timeout_us = 100000;
>>